Skip to content

Commit 3d3428a

Browse files
authored
Merge pull request #5408 from kolyshkin/1.4-5401
[1.4] ci: fix conmon job
2 parents af30329 + 06c4efc commit 3d3428a

1 file changed

Lines changed: 15 additions & 2 deletions

File tree

‎.github/workflows/validate.yml‎

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,11 @@ jobs:
289289
- name: build runc
290290
run: make
291291

292+
- name: Allow userns for runc
293+
# https://discourse.ubuntu.com/t/ubuntu-24-04-lts-noble-numbat-release-notes/39890#unprivileged-user-namespace-restrictions-15
294+
run: |
295+
sed "s;^profile runc /usr/sbin/;profile runc-test $PWD/;" < /etc/apparmor.d/runc | sudo apparmor_parser
296+
292297
- name: setup bats
293298
uses: bats-core/bats-action@4.0.0
294299
with:
@@ -303,14 +308,22 @@ jobs:
303308
with:
304309
repository: containers/conmon
305310
path: conmon
306-
ref: v2.2.1
311+
# XXX: this is conmon main, which has a lot of test fixes (including
312+
# making the tests fail, rather than silently skip, when the test
313+
# image can not be pulled) that are not in any release yet. Switch to
314+
# a released version once one is out (> v2.2.1).
315+
ref: f4cefcd7a33932131ab1a0130ae0b0175368025a
307316

308317
- name: build conmon
309318
run: cd conmon && make
310319

311320
- name: run conmon tests
321+
# --strict turns a skipped test into a failure. We do not want any of
322+
# these tests to be silently skipped here (that is how the breakage
323+
# fixed by #5401 went unnoticed for a while), and none of them are
324+
# expected to skip in this environment.
312325
run: |
313-
RUNTIME_BINARY=$(pwd)/runc ./conmon/test/run-tests.sh -j $(nproc)
326+
RUNTIME_BINARY=$(pwd)/runc ./conmon/test/run-tests.sh --strict -j $(nproc)
314327
315328
all-done:
316329
needs:

0 commit comments

Comments
 (0)