Repository navigation
Commit 3446e1f
committed
CI: port ABI check improvements from the spec repo
Bring the loader's check-abi.yml in line with the spec repo's
loader-integration ABI check, so routine changes stop failing it.
- Downgrade Parameter_Changed_Register / Parameter_Changed_Offset to Low.
abi-dumper reads the last DWARF location entry, so -Og builds report
false register/offset moves. Real breaks still fail via the type,
added and removed rules.
- Ignore the ZE_API_VERSION_CURRENT bump (scripts/update_ze_api_version.py,
copied from the spec repo).
- Pin abi-compliance-checker to 2.3 and abi-dumper to 1.4.
- Let a reviewer accept a failure with an approval review containing
abi-failure-approved. Only approvals from users with write access on
the checked head commit count; the review re-runs the check.
- Post one PR comment with both results, from a workflow_run companion
(check-abi-comment.yml) so it works for fork PRs.
- Cache base.dump by base commit, runner image and abi-dumper version.
A push to master seeds the cache so new PRs skip the base build.
The two jobs are now one matrix job; job names are unchanged.
Tested locally with v1.33.1 -> v1.34.0, the case that failed #516:
stock 94.9% (2 problems, exit 1); with this change 100% (0 problems,
exit 0). Reverse compare (v1.34.0 -> v1.33.1) still fails: 21 problems.
Signed-off-by: Russell McGuire <russell.w.mcguire@intel.com>1 parent 350c7d0 commit 3446e1f
3 files changed
Lines changed: 382 additions & 81 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
0 commit comments