Skip to content

fix(i18n): add missing Dutch translations#2957

Merged
ghostdevv merged 24 commits into
npmx-dev:mainfrom
larsdouweschuitema:fix/improve-dutch-translations
Jun 30, 2026
Merged

fix(i18n): add missing Dutch translations#2957
ghostdevv merged 24 commits into
npmx-dev:mainfrom
larsdouweschuitema:fix/improve-dutch-translations

Conversation

@larsdouweschuitema

@larsdouweschuitema larsdouweschuitema commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

No open issue related to Dutch translations.

🧭 Context

Dutch language contains incorrect and missing translations.

📚 Description

All translations were reviewed and manually tested in a local environment.

  • Some keys were incorrectly translated in a sentence. For example, "affiliëerd" should be "geaffilieerd"
  • Some keys were wrongly typed. For example, "geregisteerd" should be "geregistreerd"
  • Some keys were using English term. For example, "trademark" instead of "handelsmerk"
  • Mix of informal and formal pronouns (u/jij) was used. Majority of existing translations uses formal style and so I opted for a consistent formal style of pronouns.
  • Mixed pronouns were used (u/uw, je/jij). The majority of usage is formal, so I opted for the formal pronouns usage
  • Translated missing keys listed in the "translation status" for the Dutch language
  • Some translations (across multiple languages in fact) use "ChatGPT-style" title capatalization, where each word starts with a capital letter. Since styles are mixed, I removed the "ChatGPT-style" capatalization for some keys
  • English translations referred to "the repository", while Dutch translation used "een repository". I aligned the Dutch translation with the English version for consistency.
  • Replaced "Wijzigingenoverzicht" with "Changelog" because I believe it is more clear to the target audience of this app. Although it is an English term, it is commonly used in technical discussions within the Netherlands. This is subjective change and chan be reverted if preferred.
  • I translated "stats" to "statistieken" where appropriate. However, I kept "stats" in the navigation menu because space is more limited and the term is common to the target audience (even if it's a non-Dutch term). This is also a subjective choice and can be adjusted if necessary.

@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jun 29, 2026 6:13pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jun 29, 2026 6:13pm
npmx-lunaria Ignored Ignored Jun 29, 2026 6:13pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Dutch locale strings are updated across command palette, package navigation, package stats, a new noodles section, compare labels, diff browser options, and privacy policy cookie text.

Changes

Dutch locale copy updates

Layer / File(s) Summary
Command palette and package navigation
i18n/locales/nl.json
Updates non-affiliation text, command palette shortcuts, package links, provenance wording, and version labels.
Noodles section
i18n/locales/nl.json
Introduces the noodles subtree with titles, carousel, lens, archive, and missing-state strings.
Package stats and chart copy
i18n/locales/nl.json
Adds package stats labels, embedding controls, and version distribution strings.
About and compare labels
i18n/locales/nl.json
Adds team role labels, updates GitHub facet strings, and changes the up_to_you wording.
Diff browser and privacy copy
i18n/locales/nl.json
Adds diff browser option strings and updates cookie text for the privacy policy.

Possibly related PRs

  • npmx-dev/npmx.dev#2772: Updates the same Dutch locale file with overlapping command-palette, compare, and privacy-policy translation keys.
  • npmx-dev/npmx.dev#2946: Touches the same translation areas in another locale, including noodles, compare facets, and diff-browser strings.
  • npmx-dev/npmx.dev#2923: Expands similar i18n keys for command palette, noodles, and chart embedding in a different locale file.

Suggested reviewers

  • ghostdevv
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description is directly about fixing and standardising Dutch translations.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately and concisely describes the main change: adding missing Dutch translations.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @larsdouweschuitema! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/nl.json Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@gameroman gameroman added i18n Related to internationalization needs review This PR is waiting for a review from a maintainer labels Jun 24, 2026

@WilcoSp WilcoSp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general good changes, only for "Changelog" & "Core" I do have suggested changes as I do think it's better to keep the English terms to a minimum.

also nice that you caught the informal translations as it should've been formal, at my work we use informal which makes it that when translating that I sometimes translate to informal instead of formal.

Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json Outdated
@gameroman gameroman removed the needs review This PR is waiting for a review from a maintainer label Jun 27, 2026
larsdouweschuitema and others added 2 commits June 29, 2026 14:14
Change "Changelog" to "Wijzigingen

Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com>
Change "changelog" to "Wijzigingen"

Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com>
larsdouweschuitema and others added 3 commits June 29, 2026 14:15
change "Core" to "Kern"

Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com>
Change "core" to "kernlid"

Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com>
@larsdouweschuitema

Copy link
Copy Markdown
Contributor Author

In general good changes, only for "Changelog" & "Core" I do have suggested changes as I do think it's better to keep the English terms to a minimum.

also nice that you caught the informal translations as it should've been formal, at my work we use informal which makes it that when translating that I sometimes translate to informal instead of formal.

Thanks for your review! I agree with all suggestions and resolved them. With regards to keeping Dutch at a minimum, I don't have a strong preference, but I can understand!

@ghostdevv ghostdevv changed the title fix(i18n): update Dutch translations fix(i18n): add missing Dutch translations Jun 30, 2026
@ghostdevv ghostdevv added this pull request to the merge queue Jun 30, 2026
@ghostdevv

Copy link
Copy Markdown
Member

Lars Douwe Schuitema requested a review from WilcoSp

Looks like there weren't many more changes since last review so we can merge this and fix anything in a follow up 😄

With regards to keeping Dutch at a minimum, I don't have a strong preference, but I can understand!

English*

Merged via the queue into npmx-dev:main with commit 492c907 Jun 30, 2026
25 checks passed
@github-actions

Copy link
Copy Markdown

Thanks for your first contribution, @larsdouweschuitema! 💫

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Related to internationalization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants