From 24950b4ebc2f0328c9229f3e0256e4e4ce9b9c57 Mon Sep 17 00:00:00 2001 From: Sunil Sharma Date: Thu, 16 Jun 2016 15:44:30 +0530 Subject: [PATCH 1/3] update project setting --- MWFeedParser-Info.plist | 2 +- MWFeedParser.xcodeproj/project.pbxproj | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/MWFeedParser-Info.plist b/MWFeedParser-Info.plist index 95f182e..3ecd686 100644 --- a/MWFeedParser-Info.plist +++ b/MWFeedParser-Info.plist @@ -11,7 +11,7 @@ CFBundleIconFile Icon.png CFBundleIdentifier - com.yourcompany.${PRODUCT_NAME:rfc1034identifier} + $(PRODUCT_BUNDLE_IDENTIFIER) CFBundleInfoDictionaryVersion 6.0 CFBundleName diff --git a/MWFeedParser.xcodeproj/project.pbxproj b/MWFeedParser.xcodeproj/project.pbxproj index f7f461c..5dc2f96 100755 --- a/MWFeedParser.xcodeproj/project.pbxproj +++ b/MWFeedParser.xcodeproj/project.pbxproj @@ -221,7 +221,7 @@ 29B97313FDCFA39411CA2CEA /* Project object */ = { isa = PBXProject; attributes = { - LastUpgradeCheck = 0420; + LastUpgradeCheck = 0730; ORGANIZATIONNAME = "Michael Waterfall"; }; buildConfigurationList = C01FCF4E08A954540054247B /* Build configuration list for PBXProject "MWFeedParser" */; @@ -292,6 +292,7 @@ GCC_PREFIX_HEADER = MWFeedParser_Prefix.pch; GCC_VERSION = com.apple.compilers.llvm.clang.1_0; INFOPLIST_FILE = "MWFeedParser-Info.plist"; + PRODUCT_BUNDLE_IDENTIFIER = "com.yourcompany.${PRODUCT_NAME:rfc1034identifier}"; PRODUCT_NAME = MWFeedParser; SDKROOT = iphoneos; VALIDATE_PRODUCT = NO; @@ -308,6 +309,7 @@ GCC_PREFIX_HEADER = MWFeedParser_Prefix.pch; GCC_VERSION = com.apple.compilers.llvm.clang.1_0; INFOPLIST_FILE = "MWFeedParser-Info.plist"; + PRODUCT_BUNDLE_IDENTIFIER = "com.yourcompany.${PRODUCT_NAME:rfc1034identifier}"; PRODUCT_NAME = MWFeedParser; SDKROOT = iphoneos; VALIDATE_PRODUCT = NO; @@ -317,9 +319,9 @@ C01FCF4F08A954540054247B /* Debug */ = { isa = XCBuildConfiguration; buildSettings = { - ARCHS = "$(ARCHS_STANDARD_INCLUDING_64_BIT)"; CLANG_ENABLE_OBJC_ARC = NO; CODE_SIGN_IDENTITY = ""; + ENABLE_TESTABILITY = YES; GCC_C_LANGUAGE_STANDARD = c99; GCC_VERSION = com.apple.compilers.llvmgcc42; GCC_WARN_ABOUT_RETURN_TYPE = YES; @@ -333,7 +335,6 @@ C01FCF5008A954540054247B /* Release */ = { isa = XCBuildConfiguration; buildSettings = { - ARCHS = "$(ARCHS_STANDARD_INCLUDING_64_BIT)"; CLANG_ENABLE_OBJC_ARC = NO; CODE_SIGN_IDENTITY = ""; GCC_C_LANGUAGE_STANDARD = c99; From cd6eb23492ce62910e35e25bd21ea540f4450ee1 Mon Sep 17 00:00:00 2001 From: Sunil Sharma Date: Thu, 16 Jun 2016 15:46:21 +0530 Subject: [PATCH 2/3] Bit code is disabled in project setting as it is supporting below iOS 6 --- MWFeedParser.xcodeproj/project.pbxproj | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/MWFeedParser.xcodeproj/project.pbxproj b/MWFeedParser.xcodeproj/project.pbxproj index 5dc2f96..2d673e3 100755 --- a/MWFeedParser.xcodeproj/project.pbxproj +++ b/MWFeedParser.xcodeproj/project.pbxproj @@ -285,7 +285,9 @@ buildSettings = { ALWAYS_SEARCH_USER_PATHS = NO; CLANG_ENABLE_OBJC_ARC = YES; + CODE_SIGN_IDENTITY = "iPhone Developer"; COPY_PHASE_STRIP = NO; + ENABLE_BITCODE = NO; GCC_DYNAMIC_NO_PIC = NO; GCC_OPTIMIZATION_LEVEL = 0; GCC_PRECOMPILE_PREFIX_HEADER = YES; @@ -304,7 +306,9 @@ buildSettings = { ALWAYS_SEARCH_USER_PATHS = NO; CLANG_ENABLE_OBJC_ARC = YES; + CODE_SIGN_IDENTITY = "iPhone Developer"; COPY_PHASE_STRIP = YES; + ENABLE_BITCODE = NO; GCC_PRECOMPILE_PREFIX_HEADER = YES; GCC_PREFIX_HEADER = MWFeedParser_Prefix.pch; GCC_VERSION = com.apple.compilers.llvm.clang.1_0; From 439da81649727f7083675a407705fbbf4a878341 Mon Sep 17 00:00:00 2001 From: Sunil Sharma Date: Thu, 16 Jun 2016 15:48:03 +0530 Subject: [PATCH 3/3] Fix warning 'sizeWithFont:constrainedToSize:lineBreakMode:' is deprecated: --- Classes/DetailTableViewController.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Classes/DetailTableViewController.m b/Classes/DetailTableViewController.m index cde2bdc..57f3989 100644 --- a/Classes/DetailTableViewController.m +++ b/Classes/DetailTableViewController.m @@ -160,9 +160,9 @@ - (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPa // Get height of summary NSString *summary = @"[No Summary]"; if (summaryString) summary = summaryString; - CGSize s = [summary sizeWithFont:[UIFont systemFontOfSize:15] - constrainedToSize:CGSizeMake(self.view.bounds.size.width - 40, MAXFLOAT) // - 40 For cell padding - lineBreakMode:UILineBreakModeWordWrap]; + NSMutableParagraphStyle *paragraphStyle = [[NSMutableParagraphStyle defaultParagraphStyle] mutableCopy]; + paragraphStyle.lineBreakMode = NSLineBreakByWordWrapping; + CGSize s = [summary boundingRectWithSize:CGSizeMake(self.view.bounds.size.width - 40, MAXFLOAT) options:NSStringDrawingUsesLineFragmentOrigin attributes:@{NSFontAttributeName: [UIFont systemFontOfSize:15], NSParagraphStyleAttributeName: paragraphStyle} context:nil].size; return s.height + 16; // Add padding }