Servo mixing under Flying Wing mode not working on latest release. (2015-08-27)

[Nandox7]

Hey,

Tried to update to the latest FW release (2015-08-27) and the servo mixing in Fling Wing Mode doesn't work.
Reverting to the previous one, makes it work. (2015-07-11)

Checking latest commits this one may be the culprit: ba9c0d2
I'll be running a few more tests with it.

[trollcop]

I'll be looking forward a patch that fixes it ;)
On Sep 6, 2015 23:37, "Nandox7" notifications@github.com wrote:

Hey,

Tried to update to the latest FW release (2015-08-27) and the servo mixing
in Fling Wing Mode doesn't work.
Reverting to the previous one, makes it work. (2015-07-11)

Checking latest commits this one may be the culprit: ba9c0d2
ba9c0d2
I'll be running a few more tests with it.

—
Reply to this email directly or view it on GitHub
#296.

[EmilsPa]

Non of the Servo models work any more.
Planes and TRI copter
The servo Tab don't contain any data.

[trollcop]

cool
On Sep 9, 2015 01:05, "EmilsPa" notifications@github.com wrote:

Non of the Servo models work any more.
Planes and TRI copter
The servo Tab don't contain any data.

—
Reply to this email directly or view it on GitHub
#296 (comment)
.

[readerror67]

Can't we just roll back the stuff lazd commited ?

[trollcop]

how about getting him to fix it instead?
On Sep 9, 2015 01:17, "readerror67" notifications@github.com wrote:

Can't we just roll back the stuff lazd commited ?

—
Reply to this email directly or view it on GitHub
#296 (comment)
.

[readerror67]

Hes over on cleanflight now?

[Nandox7]

I'm on Holiday's shouldn't be looking into code but...I want it to fly my
wing. :)

Yesterday I checked it a bit. Seems the mixer is a bit messed.
I got it just half working by changing the custom servo mixer to load only
when the new feature is enabled.
I'd get elevator mix but not ailerons so there is more to check in there.

I could be wrong but seems the mixer rules are overriding itself.
On 8 Sep 2015 17:22, "readerror67" notifications@github.com wrote:

Hes over on cleanflight now?

—
Reply to this email directly or view it on GitHub
#296 (comment)
.

[schugabe]

baseflight/src/mixer.c

Line 333 in ba9c0d2

if (core.useServo)

The condition in this line is wrong!
It should be mcfg.mixerConfiguration == MULTITYPE_CUSTOM_PLANE

[schugabe]

Actually it's not that easy any more. It should load the custom mixer if we have a MULTITYPE_CUSTOM_PLANE or the feature SERVO_MIXER is active and the current model type does not have a default servo mixer.

Or should the feature SERVO_MIXER always activate the custom servo mixer chain?

if (mcfg.mixerConfiguration == MULTITYPE_CUSTOM_PLANE || feature(FEATURE_SERVO_MIXER))
            loadCustomServoMixer();

[Nandox7]

@schugabe that was my first change as well. But doing that only makes the elevator mix work the ailerons still don't work.

What I did was to leave the current check and add and extra one for the feature.

if (core.useServo & feature(FEATURE_SERVO_MIXER))
         loadCustomServoMixer();

[dustin]

@lazd Any input? Your change seems to have negatively impacted people.

[trollcop]

left a turd at front door and ran away?
On Sep 9, 2015 01:21, "readerror67" notifications@github.com wrote:

Hes over on cleanflight now?

—
Reply to this email directly or view it on GitHub
#296 (comment)
.

[lazd]

I don't see why it wouldn't work, as it checked useServo for the mixer type and ran the servo mixer if it was on. Maybe @schugabe and @Nandox7 were unable to setup their servo mixes correctly using the smix command.