tests: allow retries on transient bind errors (WSAEADDRNOTAVAIL, WSAEADDRINUSE) in socket_helper - #5515
Merged
Shankar Seal (shankarseal) merged 3 commits intoSep 14, 2026
Conversation
…ADDRINUSE) in socket_helper
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Contributor
D. Michael Agun (mikeagun)
approved these changes
Aug 29, 2026
adri22235
requested review from
Andrew Beltrano (abeltrano) and
Maksim S. (maxsud)
as code owners
August 30, 2026 18:45
Contributor
1 similar comment
Contributor
| } | ||
|
|
||
| if (expected_bind_error == 0 && !_bind_succeeded) { | ||
| FAIL("Failed to bind socket after retries with error: " << _actual_bind_error); |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In CI test runners (such as Windows Server 2025 virtual machine environments), IPv6 and Dual Stack local interface bindings can experience transient delays during socket initialization, returning
WSAEADDRNOTAVAIL(10049) orWSAEADDRINUSE(10048).Currently,
_base_socket::_base_socketimmediately invokesFAIL()on any error other thanWSAENOBUFS, aborting on the very first attempt without utilizing the 5-iteration retry loop.Fix:
is_transient_errorhelper intests/libs/util/socket_helper.cppto recognizeWSAEADDRNOTAVAIL(10049) andWSAEADDRINUSE(10048) alongsideWSAENOBUFS(10055).Sleep(1000)to retry binding during transient adapter readiness delays.Testing
tests/libs/util/socket_helper.cpp.