Repository navigation
fix(updates): ignore files inside RNRepo caches in the fingerprint - #930
Merged
Merged
Conversation
RNRepo writes prebuilt frameworks into node_modules/<package>/.rnrepo-cache/ during pod install. The pattern **/.rnrepo-cache matched only the folder, so the fingerprint still hashed the files inside it. The build folder runs pod install before EAS checks the runtime version, so its fingerprint did not match the fingerprint from the runner.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
✅ OTA compatibleThis PR does not change the native fingerprint. It can ship as an OTA update. Fingerprints against the base commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is the real cause of the "Runtime version mismatch" failures in
deploy-ota-or-native(failed run). #929 works around them by going back toappVersion.The EAS build folder runs
pod installbefore it calculates the runtime version. Duringpod install, RNRepo writes prebuilt frameworks intonode_modules/<package>/.rnrepo-cache/. The fingerprint hashes every native package folder..fingerprintignorehad**/.rnrepo-cache, which matches only the folder, not the files inside it. So the build hashed nine packages differently from the runner:How
Test Plan
I reproduced commit
b8bea11locally with the production secrets from 1Password and the CI env. I fingerprinted a copy packed the way EAS packs it (.easignore, no.git) after each build step:cbb67b4…and1314dea…are the exact hashes from the failed run. The runner hash does not change, so the fingerprint cache in S3 stays valid. This change alone does not trigger a native build.Merge Danger
Door: two-way. Revert the one line to go back.
Blast Radius: fingerprints.
Files inside
.rnrepo-cachefolders no longer count towards the fingerprint. They are build caches that RNRepo creates, not source. After this merges,runtimeVersion.policycan go back tofingerprint(revert #929).