Repository navigation
Fix Deploy Dashboard: stop slug-twin models from sharing a logo review ID - #814
Merged
Merged
Conversation
models.json keeps live records whose slugs collide, such as "Gemini 2.5 Flash" and "Gemini-2.5-Flash". Rename inheritance in build_logo_registry.py handed the new label its still-live twin's ID, so 36 model cards shared an ID and test_review_ids_are_frozen failed the Pages build (946 IDs, 910 unique). Inherit only from labels the data no longer carries, and let each retired ID be claimed once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xy5io9WxsQmk5G9cqmNjKV
Owner
Author
|
330226 claude-opus-5-5 Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Deploy Dashboard has failed on every
mainpush since run 338 (e.g. https://github.com/ktwu01/benchmark-radar/actions/runs/37723739921). The only failing test istests/test_logo_audit.py::test_review_ids_are_frozen_so_feedback_survives_a_rebuild: 946 model cards, only 910 distinct IDs. CI on the same commits stays green because only the Pages workflow runsscripts/build_logo_registry.pybeforepytest.Why
models.jsonnow keeps separate live records whose slugs collide, e.g.Gemini 2.5 Flash/Gemini-2.5-FlashorStep 3.5 Flash/Step-3.5-Flash(36 pairs). The registry's rename inheritance maps each new label to the ID of an existing label with the samemodel_keyslug, even when that existing label is still live, so both cards ended up with one ID.Fix
models.json(a genuine rename likeGrok-4→Grok 4), and each retired ID can be claimed once.test_slug_twins_that_are_both_live_get_distinct_logo_idscovers both the twin case and the rename case.No derived files are committed; CI regenerates the registry.
Verification
From a clean worktree with the submodule initialized:
ruff check .,ruff format --check .,normalize-catalog,classify,build-data-release,build_logo_registry.py, thenpytest -q→ 1789 passed. The only failure istest_briefing.py::test_zh_output_budget_covers_worst_case, aProxyErrorcaused by the sandbox's lack of network access; it passes in CI. Rebuilt registry: 946 models, 0 duplicate IDs.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xy5io9WxsQmk5G9cqmNjKV
Generated by Claude Code