Repository navigation
Conversation
|
330226 — GPT This PR was prepared by a GPT-series coding agent on behalf of @lynnzc, following AGENTS.md and CONTRIBUTING.md. The complete clean-checkout CI sequence passed locally (1,385 tests), along with 22 UI checks. The uploaded head has the same Git tree as the tested checkout. Desktop and mobile visual review remains outstanding; the proposal is opt-in and does not change the production deployment. |
Apply the visual updates directly to the existing site and page generators. Add catalog-backed research fields, preserve unrestricted benchmark search, and cover native navigation and filtering in the regression harnesses.
|
Checked corpus compliance: the default field Three asks:
Verdict: Comment. Review produced by an agent (Claude), reading the diff, the repo rule files and the cited sources, then re-checked against an independent adversarial pass. Posted as a comment rather than a blocking review. |
|
Addressed both code findings: generated benchmark pages resolve shared chrome from the repository path, with a regression test for a non-root working directory; the Research details dialog no longer renders unsupported record metadata. The repository's six-step CI sequence passed in a clean detached worktree with submodules initialized (1,387 tests). Visually checked Today and Research at desktop (1440 × 900) and mobile (390 × 844), including Research table rows and the details dialog. At both sizes, clicking the row opens the dialog, and the page has no horizontal overflow. The public preview serves the verified Research page and byte-identical JS/CSS assets: https://benchmark-radar-study.lynnzc.chatgpt.site/research/. |
|
Hi @lynnzc, thanks for this. The research navigation and a consistent visual system are both things the site needs. The PR is hard to review as one unit, though: 26 files / +1,112, combining two independent changes:
Could you split these into two PRs, with the restyle first? A reviewer can then judge the restyle from before/after screenshots (desktop and phone width, light and dark), and judge the research page on behavior. Please attach those screenshots to the restyle PR; for a visual change they are the main thing reviewers look at. Smaller items:
Generated by Claude Code |
|
@Claire1217 our cheif UI officer what do u think of this? |
|
Review: valuable direction, but too big and out of date to merge as one PR. It touches 26 files (about 1,100 added lines) across design system CSS, To get it merged:
Reminder from #510: UI changes are merged on design quality, so please keep the first screen simple. 中文:方向很好,但一次改 26 个文件且落后 main 200 个提交, Generated by Claude Code |
|
@Claire1217 our cheif UI officer what do u think of this? |
Summary
Improve the existing site's navigation, typography, spacing, and controls to make benchmark research easier to browse.
/research/, with two-level filters, source evidence, and export, through the normal site build.Validation