Skip to content

Commit 616d05d

Browse files
committed
Gate milestone check on "not main"
1 parent 0545fdd commit 616d05d

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

tools/changelog-helper.sh

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,13 @@ find_or_add_missing_entries() {
102102
local milestone
103103
for id in $(git log "${prev_release_tag}..${target_ref}" | grep -oP '#\K(\d+)'); do
104104
gh pr view "${id}" --json title &> /dev/null || continue # Skip non-PRs
105-
milestone=$(gh pr view "${id}" --json milestone --jq .milestone.title)
106-
#if [[ "${milestone}" =~ "Release " ]] && [[ "${milestone}" != "Release ${target_release}" ]]; then
107-
# echo "-> Ignoring PR #${id}, which was mentioned in 'git log ${prev_release_tag}..${target_ref}', but already has milestone '${milestone}'"
108-
# continue
109-
#fi
105+
if [[ "$branch" != "main" ]]; then
106+
milestone=$(gh pr view "${id}" --json milestone --jq .milestone.title)
107+
if [[ "${milestone}" =~ "Release " ]] && [[ "${milestone}" != "Release ${target_release}" ]]; then
108+
echo "-> Ignoring PR #${id}, which was mentioned in 'git log ${prev_release_tag}..${target_ref}', but already has milestone '${milestone}'"
109+
continue
110+
fi
111+
fi
110112
check_or_add_pr "${id}"
111113
done
112114

0 commit comments

Comments
 (0)