🌱 test(crux/agent): pin LastLaunchAt wiring from manager to watchdog observation by hivecommons-hive[bot] · Pull Request #17350 · hivecommons/hive

hivecommons-hive · 2026-11-09T05:37:33Z

Test Improvement

The #17320 fix dates watchdog boot grace from the most recent CLI relaunch. That only works if two writes survive: markCLILaunchedLocked stamping lastCLILaunchAt, and WatchdogFleet.Observe copying it into Observation.LastLaunchAt. Both lines already ran under TestWatchdogObserveCarriesStartedAt, so they count as covered, but nothing asserted the value — deleting either write left crux/agent green while the classifier silently fell back to the agent's first start and relaunches lost their grace again.

This pins the wiring from the manager side (the watchdog side is already pinned by TestClassifyLoginChromeAfterMidLifeRelaunch):

TestWatchdogObserveCarriesStartedAt now also asserts LastLaunchAt is zero when no CLI launch has been recorded.
TestWatchdogObserveCarriesLastLaunchAt: a relaunch 22h after start reaches the observation as LastLaunchAt without rewriting StartedAt.
TestMarkCLILaunchedLockedStampsEveryLaunchField: StartedAt, launchGen and lastCLILaunchAt move together, one increment per launch.

Test-only (_test.go), so no changelog fragment per the exemption set. Not run locally per AGENTS.md; CI is the verdict.

Refs #17349 — this is the fourth "covered but never asserted" site in the repository; the issue proposes the mutation gate that would have caught it in the PR, and stays open for that decision.

Filed by quality agent (ACMM L4/L6 — full mode)

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

…servation The #17320 relaunch boot grace depends on WatchdogFleet.Observe copying lastCLILaunchAt into Observation.LastLaunchAt and on markCLILaunchedLocked stamping it. Both executed under existing tests but neither value was asserted, so dropping either write left the suite green. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

kubestellar-prow · 2026-11-09T05:37:37Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-actions · 2026-11-09T05:37:42Z

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

github-actions · 2026-11-09T05:38:08Z

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

hivecommons-hive

Read the tree at v5, not just the diff. Looks correct to me.

src/crux/agent/watchdog_fleet.go:451-455 — markCLILaunchedLocked writes StartedAt, launchGen++, lastCLILaunchAt in one place; TestMarkCLILaunchedLockedStampsEveryLaunchField asserts all three after two calls (gen+2, both timestamps == second), which is exactly what would catch a dropped write.
src/crux/agent/watchdog_fleet.go:157,172 — Observe copies agent.lastCLILaunchAt under m.mu.RLock into Observation.LastLaunchAt; TestWatchdogObserveCarriesLastLaunchAt sets the field directly on m.agents["a1"] with no lock, which is fine here since Observe is the only other accessor in the test and runs after.
Zero-value assertion added to TestWatchdogObserveCarriesStartedAt is consistent: newWatchdogTestManager never calls markCLILaunchedLocked, so lastCLILaunchAt is the zero time.Time.

Body matches the diff: test-only, no changelog fragment needed. The two red checks (FOSSA license scan, docker (contributor)) cannot be caused by a _test.go-only change; every test (agent n/5) shard is green.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

hivecommons-hive · 2026-11-09T05:48:12Z

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer (folded here because this head already carries its hive review):

Read the tree on v5, not just the diff — the three new assertions match the code they pin.

src/crux/agent/watchdog_fleet.go:451-455 — markCLILaunchedLocked writes exactly StartedAt, launchGen++, lastCLILaunchAt; TestMarkCLILaunchedLockedStampsEveryLaunchField asserts all three and holds m.mu.Lock() around the call, as the helper's "Caller holds m.mu" contract requires.
src/crux/agent/watchdog_fleet.go:157 and :173 — Observe copies agent.lastCLILaunchAt under RLock into Observation.LastLaunchAt, so TestWatchdogObserveCarriesLastLaunchAt (relaunch at +22h, StartedAt untouched) and the new zero-value assertion in TestWatchdogObserveCarriesStartedAt test the actual wiring. Direct field writes before Observe follow the existing pattern at watchdog_fleet_test.go:447.

Test-only change; the changelog exemption claim is consistent with changelog-fragment-guard passing. The red FOSSA license scan and docker (contributor) checks cannot be caused by a _test.go-only diff — they look like infrastructure, not this PR.

Looks correct to me. Not approving — that is a human's signature.

hive/awaiting-ci: FOSSA license scan (FOSSA CLI fetch) and docker (contributor) (curl: (22) ... 504 fetching just/yq release assets) both failed on GitHub release downloads returning 504 at ~05:38Z; every other job on this run is green and the diff is test-only. Tracked as #17351 — deferred until a re-run; no PR-local repair needed.

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#17350 4153f62` sha256:6a9e9c81bc71434b3170daee13d694445c1e48a0e636af3f964343b4c8df418e — download from the dashboard or `hivectl review evidence #17350`.

github-actions · 2026-11-09T05:50:26Z

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 9, 2026

kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 9, 2026

github-actions Bot added the copilot label Nov 9, 2026

hivecommons-hive Bot commented Nov 9, 2026

View reviewed changes

hivecommons-hive Bot mentioned this pull request Nov 9, 2026

[scanner] [shared-ci] release-asset download 504s (FOSSA, typos, golangci-lint, docker contributor) failing across hivecommons/hive + hivecommons/docs #17351

Closed

hivecommons-hive Bot merged commit 7491bb0 into v5 Nov 9, 2026
81 of 92 checks passed

kubestellar-prow Bot deleted the quality/test-watchdog-last-launch-at branch November 9, 2026 05:50

hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 9, 2026

This was referenced Nov 9, 2026

[quality] Gate proposal: Go branches covered but never asserted (advisory mutation testing on changed packages) #17349

Closed

🐛 fix: classify BuildKit-prefixed and golangci-lint-action 5xx release downloads as runner infra #17352

Merged

clubanderson mentioned this pull request Nov 10, 2026

🌱 Top up v6 with v5 (durable hosted hive.yaml, shared-CI deferral naming and 118 more) #17506

Closed

Navigation Menu

Repository navigation

🌱 test(crux/agent): pin LastLaunchAt wiring from manager to watchdog observation - #17350

🌱 test(crux/agent): pin LastLaunchAt wiring from manager to watchdog observation#17350
hivecommons-hive[bot] merged 1 commit into
v5from
quality/test-watchdog-last-launch-at

hivecommons-hive Bot commented Nov 9, 2026

Uh oh!

kubestellar-prow Bot commented Nov 9, 2026

Uh oh!

github-actions Bot commented Nov 9, 2026

Uh oh!

github-actions Bot commented Nov 9, 2026

Uh oh!

hivecommons-hive Bot left a comment

Uh oh!

hivecommons-hive Bot commented Nov 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Nov 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

Conversation

hivecommons-hive Bot commented Nov 9, 2026

Test Improvement

Uh oh!

kubestellar-prow Bot commented Nov 9, 2026

Uh oh!

github-actions Bot commented Nov 9, 2026

Uh oh!

github-actions Bot commented Nov 9, 2026

Open PR overlap check

Uh oh!

hivecommons-hive Bot left a comment

Choose a reason for hiding this comment

Uh oh!

hivecommons-hive Bot commented Nov 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Nov 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

hivecommons-hive Bot commented Nov 9, 2026 •

edited

Loading