Skip to content

Test args are not respected by service_test #54

Description

@engnatha

Thanks for creating this module! I'm enjoying the language-agnostic way of managing test dependencies. In adopting this for a repository, I discovered that custom args supplied to the underlying test target got dropped when being executed by service_test. Our use of the rules_python py_test has some custom args specified to control how pytest is invoked under the hood.

We are working around this in our macros to pass the same args we use in py_test to the service_test target and it all works fine that way. Curious to get some thoughts on if this is the desired behavior or if there's any interest in preserving the args present in the test target that service_test references.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions