Hi Frappe team,
I wanted to open a PR for a small backward-compatible improvement in bench, but GitHub says PRs are limited to collaborators.
Change summary:
This adds an optional --authenticator flag to bench setup lets-encrypt.
Default remains standalone, so existing behavior is unchanged.
Users can run:
bench setup lets-encrypt site.local --custom-domain example.com --authenticator nginx
This is useful for production setups where Nginx is already serving HTTP traffic on port 80, and Certbot’s nginx authenticator is preferred for HTTP-01 challenge handling and renewal workflows.
Changed files:
bench/commands/setup.py
bench/config/lets_encrypt.py
bench/config/templates/letsencrypt.cfg
bench/tests/test_letsencrypt.py
docs/bench_usage.md
Branch:
https://github.com/vishalkatsa/bench/tree/feat/letsencrypt-authenticator-option
Tested with:
python3 -m unittest bench.tests.test_letsencrypt
Also tested on server:
authenticator = nginx was generated in /etc/letsencrypt/renewal/<domain>.conf
certbot renew --dry-run succeeded
Hi Frappe team,
I wanted to open a PR for a small backward-compatible improvement in bench, but GitHub says PRs are limited to collaborators.
Change summary:
This adds an optional
--authenticatorflag tobench setup lets-encrypt.Default remains
standalone, so existing behavior is unchanged.Users can run:
bench setup lets-encrypt site.local --custom-domain example.com --authenticator nginxThis is useful for production setups where Nginx is already serving HTTP traffic on port 80, and Certbot’s nginx authenticator is preferred for HTTP-01 challenge handling and renewal workflows.
Changed files:
bench/commands/setup.pybench/config/lets_encrypt.pybench/config/templates/letsencrypt.cfgbench/tests/test_letsencrypt.pydocs/bench_usage.mdBranch:
https://github.com/vishalkatsa/bench/tree/feat/letsencrypt-authenticator-option
Tested with:
python3 -m unittest bench.tests.test_letsencryptAlso tested on server:
authenticator = nginxwas generated in/etc/letsencrypt/renewal/<domain>.confcertbot renew --dry-runsucceeded