From 9a1d3748d585ac3ffe5d5b5e5e139379972ed530 Mon Sep 17 00:00:00 2001 From: Rob van Oostrum Date: Tue, 29 Jul 2025 13:31:29 -0400 Subject: [PATCH] feat: alert on rollback when canary not ready Signed-off-by: Rob van Oostrum --- pkg/controller/scheduler.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/controller/scheduler.go b/pkg/controller/scheduler.go index 12a94befc..1ea583cf7 100644 --- a/pkg/controller/scheduler.go +++ b/pkg/controller/scheduler.go @@ -348,6 +348,8 @@ func (c *Controller) advanceCanary(name string, namespace string) { if err != nil { c.recordEventWarningf(cd, "%v", err) if !retriable { + c.recordEventWarningf(cd, "Rolling back since %s.%s canary is not ready", cd.Name, cd.Namespace) + c.alert(cd, "Rolling back since canary is not ready", false, flaggerv1.SeverityError) c.rollback(cd, canaryController, meshRouter, scalerReconciler) } return