Skip to content

Commit 285fb95

Browse files
chenxin-yanericciarla
authored andcommitted
fix(setup): filter the no-npx native fallback to the selected skills
Review fixes for #203: - setup's no-npx fallback called installSkillsNative(repo) without the name filter, installing the entire catalog (build skills included) instead of the selection every other install path uses - drop the nonexistent --skills-only CLI flag from the developer-index skill (skills="only" stays HTTP/MCP-only per cli-argv contract) - note that the workflow retry hint reinstalls all workflow skills, not the picked subset - fix 'sturctural' typo in the research-index skill
1 parent a5725bb commit 285fb95

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

‎skills/firecrawl-developer-index/SKILL.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ There is **no fixed recipe**. Read the question, decide what kind it is, and cho
1313

1414
- HTTP: **`GET|POST https://api.firecrawl.dev/v2/search/developer`**
1515
MCP: **`firecrawl_developer_search(query, k?, skills?)`**
16-
CLI: **`firecrawl developer <query> [--limit <n>] [--skills-only]`**
16+
CLI: **`firecrawl developer <query> [--limit <n>]`**
1717
Ranked results over the whole index. Each carries `id` (`issue:owner/repo#123`), `url`, and the **matched passages in markdown**, so tables and code blocks survive. The artifact kind is the `id` prefix: `doc:`, `issue:`, `pull_request:`, or `readme:`.
1818
The default first move for a developer question. It is the only surface that returns the passages, which is what lets you answer instead of pointing at a page.
19-
`k` / `--limit` is 1–100 and defaults to 10. `skills="only"` / `--skills-only` restricts the search to agent-skill files.
19+
`k` / `--limit` is 1–100 and defaults to 10. `skills="only"` (HTTP/MCP only) restricts the search to agent-skill files.
2020
Keyless; send `Authorization: Bearer $FIRECRAWL_API_KEY` for higher rate limits.
2121

2222
- MCP: **`firecrawl_search(query, categories: ["developer"])`**
@@ -48,7 +48,7 @@ Only the HTTP surface takes these. On `GET`, pass `types=issue,pull_request` or
4848
- **Version-specific behaviour** → an issue's opening report describes the broken version; its resolution supersedes it. Raise `passages` to see further into the thread, and read the resolution and the linked pull request before answering. Never answer from an opening report alone.
4949
- **Scoped to one library** → `repos=["owner/name"]` when you know the slug, plus `sources` if you want its docs in the same call. If a scoped search comes back empty, read the echoed `indexed` flag first: `false` means nothing from that repo or source can ever match and no rephrasing will help — drop the scope and search the whole index, or go to the web.
5050
- **Ecosystem-wide** ("which libraries do X", "who else hit this") → no scope. Use `language` / `topic` / `min_stars` to keep to maintained repositories, accepting that this gives up all `doc` results.
51-
- **Agent skills and tooling conventions** → `skills="only"` / `--skills-only`.
51+
- **Agent skills and tooling conventions** → `skills="only"` (HTTP/MCP only).
5252
- **Comparison, opinion, news, or an unindexed project** → the open web. `firecrawl_search`, then `firecrawl_scrape` whatever deserves a full read. Combining is often right: take the contract from the index and the trade-off from the web.
5353

5454
## Principles

‎skills/firecrawl-research-index/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Find the research papers that answer a research query. Some questions have a sin
1111

1212
Paper abstracts, with full text reachable per paper. The largest share of the corpus is **biomedical and life-science** literature — **PubMed** journal articles plus **bioRxiv** and **medRxiv** preprints — so clinical, drug, gene, disease, epidemiology, and public-health questions are in scope. **arXiv** preprints cover computer science, physics, and mathematics. Coverage outside those sources is thinner: a paper that exists only behind a publisher paywall or in a niche venue may not be indexed, and the general web tools below are the fallback when it isn't.
1313

14-
There is **no fixed recipe**. Read the query, decide what kind it is, and choose the approach below. Some queries need a single search; others need heavy sturctural/semantic expansion. Don't run machinery a query doesn't call for.
14+
There is **no fixed recipe**. Read the query, decide what kind it is, and choose the approach below. Some queries need a single search; others need heavy structural/semantic expansion. Don't run machinery a query doesn't call for.
1515

1616
## The tools, and what each is uniquely good at
1717

‎src/commands/init.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -613,7 +613,7 @@ async function stepIntegrations(options: InitOptions): Promise<number | null> {
613613
if (count != null) totalSkills = (totalSkills ?? 0) + count;
614614
} catch {
615615
console.error(
616-
` ${dim}Run "firecrawl setup workflows" later to retry.${reset}`
616+
` ${dim}Run "firecrawl setup workflows" later to retry (installs all workflow skills).${reset}`
617617
);
618618
}
619619
break;

‎src/commands/setup.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ async function installSkills(
514514

515515
// Fallback: native install (no npx/Node required)
516516
try {
517-
await installSkillsNative(repo);
517+
await installSkillsNative(repo, { skills: selection.skills });
518518
} catch (error) {
519519
console.error(
520520
`Failed to install skills from ${repo}:`,

0 commit comments

Comments
 (0)