Skip to content

UI files are not present in 2.0 and 2.1 NPM packages #1704

Description

@jescalada

Is your feature request related to a problem? Please describe.
As mentioned by @re-vlad in #1702, we weren't shipping the built UI files along with the NPM release:

Image

This issue is present on both 2.0 and 2.1 releases, which should be patched or deprecated.

As a consequence, our quickstart guide no longer works as expected:

Running npx -- @finos/git-proxy does not return any particular error. However, localhost:8080 (or other URLs) fail to get served correctly since the files are missing:

Image

I believe this might have broken when I refactored the NPM publish flow to include only build files (since we were shipping the entire source before). Another culprit might be tsconfig.publish.json explicitly excluding src/ui/**.

Describe the solution you'd like
We should get the build process fixed, and set up a proper testing script (local and CI executable) so that we catch any bad packages during publish or each PR.

Additional context
#1702

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions