From 11e5850e074396e0f55965e5a63714668541ab50 Mon Sep 17 00:00:00 2001 From: Seth Falco Date: Sat, 11 Jul 2026 09:42:59 +0100 Subject: [PATCH] fix(german-sysadmin): refer to diacritics as non-ASCII letters MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The German Sysadmin task referred to characters like Ü and ß as non-Latin, however these are Latin characters. Instead, these should be considered non-ASCII. I only updated references that implied Ü/ß were not Latin. I didn't feel compelled to over specify in other cases. When discussing the Latin alphabet, conventional wisdom is that it's simply A-Z, and it's informally accepted to treat it that way. (For example, see the Wikipedia article for Latin.) So the test cases to "allow lowercase Latin letters" or the "whole lowercase Latin alphabet" are fine. Just not anything that outright declares the other characters are not Latin. --- exercises/concept/german-sysadmin/.docs/hints.md | 2 +- exercises/concept/german-sysadmin/.docs/instructions.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/exercises/concept/german-sysadmin/.docs/hints.md b/exercises/concept/german-sysadmin/.docs/hints.md index 397a54378..cf659ed94 100644 --- a/exercises/concept/german-sysadmin/.docs/hints.md +++ b/exercises/concept/german-sysadmin/.docs/hints.md @@ -21,7 +21,7 @@ ## 3. Substitute German characters -- There is a [special syntax][syntax-reference-code-points] for getting a character's code point. It can be used in guards and it works for non-Latin letters too. +- There is a [special syntax][syntax-reference-code-points] for getting a character's code point. It can be used in guards and it works for non-ASCII letters too. - There is [a built-in function][kernel-concat-list] that allows you to concatenate two lists. [syntax-reference-code-points]: https://hexdocs.pm/elixir/syntax-reference.html#integers-in-other-bases-and-unicode-code-points diff --git a/exercises/concept/german-sysadmin/.docs/instructions.md b/exercises/concept/german-sysadmin/.docs/instructions.md index 7d568289d..7369af084 100644 --- a/exercises/concept/german-sysadmin/.docs/instructions.md +++ b/exercises/concept/german-sysadmin/.docs/instructions.md @@ -2,7 +2,7 @@ You are working as a system administrator for a big company in Munich, Germany. One of your responsibilities is managing email accounts. -You have been hearing complaints from people saying they are unable to write emails to Mr. Müller. You quickly realize that most of the company uses an old email client that doesn't recognize `müller@firma.de` as a valid email address because of the non-Latin character. +You have been hearing complaints from people saying they are unable to write emails to Mr. Müller. You quickly realize that most of the company uses an old email client that doesn't recognize `müller@firma.de` as a valid email address because of the non-ASCII character. Telling people to give up their favorite old email client is a lost battle, so you decide to create sanitized aliases for all email accounts. @@ -26,9 +26,9 @@ Username.sanitize(~c"mark_fischer$$$") ## 3. Substitute German characters -There are 4 non-Latin characters in the German alphabet, and all of them have commonly-recognized Latin substitutes. +There are 4 non-ASCII characters in the German alphabet, and all of them have commonly-recognized ASCII substitutes. -| German character | Latin substitute | +| German character | ASCII substitute | | ---------------- | ---------------- | | ä | ae | | ö | oe |