Suppress advertising manifest messages unless verbosity is diagnostic#55276
Suppress advertising manifest messages unless verbosity is diagnostic#55276marcpopMSFT with Copilot wants to merge 7 commits into
Conversation
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Changed _validationMessagesDisplayed flag from instance-level to static to ensure "Skipping NuGet package signature verification." message appears only once across all NuGetPackageDownloader instances during workload operations, rather than once per instance. Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
@copilot fix the failed build: I believe it should be TestAssetsManager instead. |
|
Tested in codespace. Confirmed that we don't see the advertising manifest messages anymore in manifest mode unless diag verbosity is used. |
…in ItSuppressesMessagesWhenDisplayManifestUpdatesIsFalse Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
|
@copilot The test GivenANonSignedSdkItShouldPrintMessageOnce failed as it expected to find GivenANonSignedSdkItShouldPrintMessageOnce in the output. Is that now suppressed because of this change? I don't think that was intentional as this change was only meant to change the advertising manifest messages. |
…nSignedSdkItShouldPrintMessageOnce test Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Confirmed — making |
Port of the first 5 commits from #51560 (targeting
release/10.0.4xx) ontomain, without the accumulated merge commits.Changes
WorkloadManifestUpdater— adds adisplayManifestUpdatesbool parameter; advertising manifest messages (e.g.AdManifestPackageDoesNotExist) are only emitted whentrueinstall,update,list) — passdisplayManifestUpdatesbased on whether verbosity isdiagnostic; all other verbosity levels suppress these messagesCommonOptionsExtensions— addsIsDiagnostic()extension onVerbosityOptionsNuGetPackageDownloader— makes_validationMessagesDisplayedstaticso "Skipping NuGet package signature verification." appears at most once per process, not once per downloader instanceItSuppressesMessagesWhenDisplayManifestUpdatesIsFalse; updatedHideManifestUpdatesWhenVerbosityIsMinimalOrNormalto include--verbosity:detailed; renamedShowManifestUpdatesWhenVerbosityIsDetailedOrDiagnostic→ShowManifestUpdatesWhenVerbosityIsDiagnosticwith only thediagnosticdata rowConflicts resolved during cherry-pick:
usingdirectives inCommonOptionsExtensions.cs(main had added three additional usings post-branch); xUnit[Fact]/[Theory]/[InlineData]test attributes converted to MSTest equivalents.