Skip to content

Add System.Uri and System.UriBuilder threat model references to API docs - #12418

Merged
MihaZupan merged 4 commits into
mainfrom
copilot/add-uri-threat-model-references
Aug 5, 2026
Merged

Add System.Uri and System.UriBuilder threat model references to API docs#12418
MihaZupan merged 4 commits into
mainfrom
copilot/add-uri-threat-model-references

Conversation

Copilot AI commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

dotnet/runtime#124273 published threat model documents for System.Uri and System.UriBuilder. These should be referenced from the API reference pages, complementing the conceptual docs changes in dotnet/docs#52465.

Changes

  • xml/System/Uri.xml — Expanded remarks to include threat model links; added <related type="ExternalDocumentation"> entries for both documents
  • xml/System/UriBuilder.xml — Added threat model links to existing remarks; added <related type="ExternalDocumentation"> entries

Both files link to:

Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the API reference documentation for System.Uri and System.UriBuilder to include links to newly published threat model documents, so readers can find design and security considerations directly from the API pages.

Changes:

  • Expanded <remarks> content to include links to the System.Uri and System.UriBuilder threat model documents.
  • Added <related type="ExternalDocumentation"> entries pointing to the same threat model documents.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
xml/System/Uri.xml Converts remarks to markdown and adds threat model links plus external related links.
xml/System/UriBuilder.xml Adds threat model links to remarks and adds external related links.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread xml/System/UriBuilder.xml Outdated
Comment thread xml/System/Uri.xml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@MihaZupan
MihaZupan marked this pull request as ready for review March 18, 2026 21:05
@MihaZupan
MihaZupan requested review from a team as code owners March 18, 2026 21:05
@MihaZupan

Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>

Copilot AI commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in 83bd210. main already contains the expanded remarks with the threat model links (they landed via the remarks-restoration change), so the remaining delta in this PR is just the two <related type="ExternalDocumentation"> entries in Uri.xml and UriBuilder.xml.

Copilot AI requested a review from MihaZupan August 5, 2026 12:01
Comment thread xml/System/UriBuilder.xml Outdated
@MihaZupan
MihaZupan enabled auto-merge (squash) August 5, 2026 14:10
@MihaZupan
MihaZupan merged commit 2511a2e into main Aug 5, 2026
7 checks passed
@MihaZupan
MihaZupan deleted the copilot/add-uri-threat-model-references branch August 5, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants