Skip to content

Commit 07e27e9

Browse files
authored
Merge pull request #657 from dice-group/refactor/tree-learner-logging
Route TDL (tree_learner) output through logging instead of print
2 parents cf421ae + 7a9f6aa commit 07e27e9

3 files changed

Lines changed: 16 additions & 18 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ date) and use that section as the basis for the GitHub release notes.
2929
`logging` instead of `print`, without the ANSI colour codes, so the output can be filtered or
3030
silenced with the standard logging configuration. A leftover debug `print(num_workers)` in
3131
`NCES2.train` is now a debug log.
32+
- `TDL` / `TDL_refinement` (`learners/tree_learner.py`) report progress (feature extraction,
33+
training, grid-search parameters, classification report) through `logging` instead of `print`.
34+
The duplicate verbose `print` after each "Error extracting ... features" warning is removed,
35+
as the same error was already logged.
3236
- Re-enabled `tests/test_semantic_cache.py` (previously 100% commented out), exercising only the
3337
symbolic (HermiT) reasoner; the neural (EBR) path is left out as in-process KGE training
3438
alongside the JVM segfaulted CI (#515).

‎Improvements.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ none remain open as of this writing.
2828
appropriate levels — `info`/`warning`/`debug`/`error`) in
2929
`knowledge_base.py`, `semantic_caching.py`,
3030
`learners/tree_learner_refinement_inherit.py`,
31-
`learners/nces.py`, `learners/nces2.py`,
31+
`learners/nces.py`, `learners/nces2.py`, `learners/tree_learner.py`,
3232
`learners/spell_kit/structures.py` (except `structure_to_dot`, whose
3333
`print()`s are genuine DOT-graph text output, not log messages), and
34-
`learners/drill.py`. `print(` still appears **~245 times** across the rest
35-
of `ontolearn/**/*.py`; remaining offenders include `learners/tree_learner.py` (16),
34+
`learners/drill.py`. `print(` still appears **~230 times** across the rest
35+
of `ontolearn/**/*.py`; remaining offenders include
3636
`learners/celoe.py` (11), `learners/sparql_query_learner.py` (4), and
3737
`data_struct.py` (10) — several of these overlap with the broad-except
3838
cleanup below and are best converted alongside that work. Routing the rest

‎ontolearn/learners/tree_learner.py‎

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ def __init__(self, knowledge_base,
325325
isinstance(knowledge_base, KnowledgeBase)
326326
or isinstance(knowledge_base, ontolearn.triple_store.TripleStore)
327327
), "knowledge_base must be a KnowledgeBase or TripleStore instance"
328-
print(f"Knowledge Base: {knowledge_base}")
328+
logger.info(f"Knowledge Base: {knowledge_base}")
329329
self.grid_search_over = grid_search_over
330330
self.kwargs_grid_search = kwargs_grid_search
331331
self.knowledge_base = knowledge_base
@@ -456,7 +456,7 @@ def extract_expressions_from_owl_individuals(self, individuals: List[OWLNamedInd
456456
)
457457
raise AssertionError(error_msg)
458458
if self.verbose > 0:
459-
print(f"Unique OWL Class Expressions as features: {len(features)}")
459+
logger.info(f"Unique OWL Class Expressions as features: {len(features)}")
460460
feature_options = {
461461
"inverse properties": self.use_inverse,
462462
"nominals": self.use_nominals,
@@ -469,7 +469,7 @@ def extract_expressions_from_owl_individuals(self, individuals: List[OWLNamedInd
469469
enabled = [name for name, flag in feature_options.items() if flag]
470470

471471
if enabled:
472-
print(f"Enabled feature types: {', '.join(enabled)}")
472+
logger.info(f"Enabled feature types: {', '.join(enabled)}")
473473

474474
# Convert features dict to list
475475
features_list = [v for k, v in features.items()]
@@ -539,8 +539,6 @@ def _extract_inverse_property_features(self, individual: OWLNamedIndividual,
539539
break # Found at least one, that's enough for the feature
540540
except Exception as e:
541541
logger.warning("Error extracting inverse property features for %s: %s", individual, e, exc_info=True)
542-
if self.verbose > 0:
543-
print(f"Warning: Error extracting inverse property features: {e}")
544542

545543
def _extract_data_property_features(self, individual: OWLNamedIndividual,
546544
features: Dict[str, OWLClassExpression],
@@ -560,8 +558,6 @@ def _extract_data_property_features(self, individual: OWLNamedIndividual,
560558
pass
561559
except Exception as e:
562560
logger.warning("Error extracting data property features for %s: %s", individual, e, exc_info=True)
563-
if self.verbose > 0:
564-
print(f"Warning: Error extracting data property features: {e}")
565561

566562
def _extract_cardinality_features(self, individual: OWLNamedIndividual,
567563
features: Dict[str, OWLClassExpression],
@@ -606,14 +602,12 @@ def _extract_cardinality_features(self, individual: OWLNamedIndividual,
606602
features[str_dl_concept] = min_card
607603
except Exception as e:
608604
logger.warning("Error extracting cardinality features for %s: %s", individual, e, exc_info=True)
609-
if self.verbose > 0:
610-
print(f"Warning: Error extracting cardinality features: {e}")
611605

612606

613607
def create_training_data(self, learning_problem: PosNegLPStandard, start_time:float=None) -> Tuple[pd.DataFrame, pd.DataFrame]:
614608
# (1) Initialize ordering over positive and negative examples.
615609
if self.verbose > 0:
616-
print("Creating a Training Dataset")
610+
logger.info("Creating a Training Dataset")
617611
positive_examples: List[OWLNamedIndividual]
618612
negative_examples: List[OWLNamedIndividual]
619613
positive_examples = [i for i in learning_problem.pos]
@@ -686,11 +680,11 @@ def _fit_decision_tree(self, X: pd.DataFrame, y: pd.DataFrame) -> None:
686680
grid_search = sklearn.model_selection.GridSearchCV(
687681
tree.DecisionTreeClassifier(**self.kwargs_classifier),
688682
param_grid=self.grid_search_over, **self.kwargs_grid_search).fit(X.values, y.values)
689-
print(grid_search.best_params_)
683+
logger.info(f"Best grid search parameters: {grid_search.best_params_}")
690684
self.kwargs_classifier.update(grid_search.best_params_)
691685
# Training
692686
if self.verbose > 0:
693-
print("Training starts!")
687+
logger.info("Training starts!")
694688
self.clf = tree.DecisionTreeClassifier(**self.kwargs_classifier).fit(X=X.values, y=y.values)
695689

696690
def _report_and_plot(self, X: pd.DataFrame, y: pd.DataFrame) -> None:
@@ -703,7 +697,7 @@ def _report_and_plot(self, X: pd.DataFrame, y: pd.DataFrame) -> None:
703697
target_names=["Negative",
704698
"Positive"])
705699
if self.verbose > 0:
706-
print(self.__classification_report)
700+
logger.info(self.__classification_report)
707701
if self.plot_tree:
708702
plot_decision_tree_of_expressions(feature_names=[owl_expression_to_dl(f) for f in self.features],
709703
cart_tree=self.clf)
@@ -720,12 +714,12 @@ def _finalize_predictions(self, X: pd.DataFrame, y: pd.DataFrame) -> None:
720714
# ending in a leaf node.
721715
self.conjunctive_concepts: List[OWLObjectIntersectionOf]
722716
if self.verbose > 0:
723-
print("Computing conjunctive_concepts...")
717+
logger.info("Computing conjunctive_concepts...")
724718
self.conjunctive_concepts = self.construct_owl_expression_from_tree(X, y)
725719
for i in self.conjunctive_concepts:
726720
self.owl_class_expressions.add(i)
727721
if self.verbose > 0:
728-
print("Computing disjunction_of_conjunctive_concepts...")
722+
logger.info("Computing disjunction_of_conjunctive_concepts...")
729723
self.disjunction_of_conjunctive_concepts = concepts_reducer(concepts=self.conjunctive_concepts, reduced_cls=OWLObjectUnionOf)
730724

731725
if self.verbalize:

0 commit comments

Comments
 (0)