Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reduce_rightreverses sequence values and then numbers them from zero, so three-argument callbacks receive the wrong original indexes. For example:Reverse the original key/value pairs instead. This also fixes
reductions_rightandreductions(..., from_right=True), while preserving mapping keys and input order. Six regressions cover lists, tuples, iterators, and reductions with and without an initial accumulator.Validation against baseline
ef6a6427e488e29e827e0e0819f2630ad3ff4cdcand candidate5674ec55d429ade516688fe696688d588b246aa9:py310,py311,py312,py313,py314all pass: package build, strict Sphinx docs, Ruff, mypy, generated chaining types, and 2,886 unit/doctests with 100% coverage each.Commands, versions, source manifests, logs, and consumer proof. GitHub CI will run after submission; these are local results.
AI assistance: implemented and validated with OpenAI Codex.