Assign tickets to any real account; main no longer has a system actor.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: chaosk

backend/druks/contrib/software_factory/issues/routes.py

@@ -45,11 +45,10 @@ async def require_ticket(identifier: str) -> Ticket:
 
 
 async def require_assignee(assignee_id: str) -> None:
-    """A ticket is assigned to a real, non-system account or to nobody. The
-    assignee FK is RESTRICT, so a bad id would surface as a 500 IntegrityError
-    on write — check it here instead, where the answer is a 404 the form can
-    show. The system account is druks' own actor, never someone to hand work to."""
-    if not await Account.get(assignee_id, exclude_system=True):
+    """A ticket is assigned to a real account or to nobody. The assignee FK is
+    RESTRICT, so a bad id would surface as a 500 IntegrityError on write —
+    check it here instead, where the answer is a 404 the form can show."""
+    if not await Account.get(assignee_id):
         raise HTTPException(http_status.HTTP_404_NOT_FOUND, f"no account {assignee_id!r}")
 
 

backend/tests/software_factory/test_issues_routes.py

@@ -1,4 +1,3 @@
-from druks.accounts.constants import SYSTEM_ACCOUNT_ID
 from druks.accounts.models import Account
 from druks.api.server import app as api
 from druks.contrib.software_factory.issues.enums import Status
@@ -218,25 +217,25 @@ async def test_blank_title_and_body_are_refused(druks_client):
     assert commented.status_code == 422
 
 
-async def test_unknown_ticket_and_system_assignee_are_404(druks_client):
+async def test_unknown_ticket_and_unknown_assignee_are_404(druks_client):
     missing = await druks_client.get(f"{_TICKETS}/DRU-99")
     assert missing.status_code == 404
 
     project = await _open_project(druks_client)
     assigned = await druks_client.post(
         _TICKETS,
         json={
-            "title": "handed to the system",
+            "title": "handed to nobody real",
             "project_id": project["id"],
-            "assignee_id": SYSTEM_ACCOUNT_ID,
+            "assignee_id": "not-an-account",
         },
     )
     assert assigned.status_code == 404
 
     ticket = await _open_ticket(druks_client, project["id"])
     updated = await druks_client.patch(
         f"{_TICKETS}/{ticket['identifier']}",
-        json={"assignee_id": SYSTEM_ACCOUNT_ID},
+        json={"assignee_id": "not-an-account"},
     )
     assert updated.status_code == 404