Commit 5860d14
committed
cli: single-site the store path, and record why the connection rung must NOT be
WERNI's duplicate-value audit run on this tree (grep the DEFAULT VALUE, not the
function, because an internal copy twelve lines from the original reads as one
behaviour). Two candidates, opposite dispositions, and the second is the useful one.
*** THE ONE I NEARLY BROKE ***
The connection ladder's HOME rung rebuilds `.local/share` — the prefix
`default_data_home()` derives twelve lines above it. That is exactly the shape the audit
exists to find, and collapsing them would have been a defect:
default_data_home() where THIS MODULE's data lives — XDG_DATA_HOME first, then the
Windows AppData rungs, then HOME/.local/share
the ladder's rung where `ck` LOOKS — HOME only, matching subc-core's
PROD_CONNECTION_RELATIVE_PATH
Re-derived at source: `ck`'s reader consults HOME and does NOT consult XDG_DATA_HOME for
that rung. So routing mine through `default_data_home()` would make this CLI look
somewhere `ck` never looks the moment an operator sets XDG_DATA_HOME — reintroducing the
looks-where-ck-does-not class that the SUBC_CONNECTION_FILE fix closed in this same
function two commits ago, by way of tidying.
Recorded at the site rather than in this message, because the audit will report the pair
again and the obvious remedy is the defect. A reported duplicate is a candidate until it
is resolved against the other side's AUTHORITY; these two have different authorities.
*** THE ONE THAT WAS REAL ***
Five identical `global.data_dir.join("store.db")` calls across the lease-free read verbs.
No second authority makes that correct — the daemon opens the same file from the same
dir through cortexkit-store — so it is five places for a rename to land in four. One
helper now.
Gate green, floor unchanged (no tests added; both changes are shape).1 parent 4f8b1f8 commit 5860d14
1 file changed
Lines changed: 36 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2683 | 2683 | | |
2684 | 2684 | | |
2685 | 2685 | | |
2686 | | - | |
| 2686 | + | |
2687 | 2687 | | |
2688 | 2688 | | |
2689 | 2689 | | |
| |||
3195 | 3195 | | |
3196 | 3196 | | |
3197 | 3197 | | |
3198 | | - | |
| 3198 | + | |
3199 | 3199 | | |
3200 | 3200 | | |
3201 | 3201 | | |
| |||
3274 | 3274 | | |
3275 | 3275 | | |
3276 | 3276 | | |
3277 | | - | |
| 3277 | + | |
3278 | 3278 | | |
3279 | 3279 | | |
3280 | 3280 | | |
| |||
3453 | 3453 | | |
3454 | 3454 | | |
3455 | 3455 | | |
3456 | | - | |
| 3456 | + | |
3457 | 3457 | | |
3458 | 3458 | | |
3459 | 3459 | | |
| |||
3667 | 3667 | | |
3668 | 3668 | | |
3669 | 3669 | | |
3670 | | - | |
| 3670 | + | |
3671 | 3671 | | |
3672 | 3672 | | |
3673 | 3673 | | |
| |||
3821 | 3821 | | |
3822 | 3822 | | |
3823 | 3823 | | |
| 3824 | + | |
| 3825 | + | |
| 3826 | + | |
| 3827 | + | |
| 3828 | + | |
| 3829 | + | |
| 3830 | + | |
| 3831 | + | |
| 3832 | + | |
| 3833 | + | |
| 3834 | + | |
3824 | 3835 | | |
3825 | 3836 | | |
3826 | 3837 | | |
| |||
3854 | 3865 | | |
3855 | 3866 | | |
3856 | 3867 | | |
| 3868 | + | |
| 3869 | + | |
| 3870 | + | |
| 3871 | + | |
| 3872 | + | |
| 3873 | + | |
| 3874 | + | |
| 3875 | + | |
| 3876 | + | |
| 3877 | + | |
| 3878 | + | |
| 3879 | + | |
| 3880 | + | |
| 3881 | + | |
| 3882 | + | |
| 3883 | + | |
| 3884 | + | |
| 3885 | + | |
| 3886 | + | |
| 3887 | + | |
3857 | 3888 | | |
3858 | 3889 | | |
3859 | 3890 | | |
| |||
0 commit comments