Skip to content

ဏ္ဍRevert "Security: pin GitHub Actions to SHA hashes" - #55

Open
saisaigdo-cmyk wants to merge 1 commit into
codacy:masterfrom
saisaigdo-cmyk:revert-51-security/pin-actions-to-sha
Open

saisaigdo-cmyk wants to merge 1 commit into
codacy:masterfrom
saisaigdo-cmyk:revert-51-security/pin-actions-to-sha

Conversation

@saisaigdo-cmyk

Copy link
Copy Markdown

Reverts #51

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reintroduces a high-severity supply-chain vulnerability by replacing immutable GitHub Action SHAs with mutable tags in workflows that access Jira credentials and GitHub tokens. Do not merge until third-party actions are restored to verified full commit-SHA pins.

Codacy reports the changes are up to standards, but its quality result does not address this security risk. No acceptance criteria are otherwise identified as unaddressed; however, the required workflow validation scenarios are missing.

About this PR

  • This change intentionally reintroduces mutable GitHub Action references across workflows handling repository and Jira credentials. Restore verified commit-SHA pinning consistently before merging.

Test suggestions

  • Validate comment_issue.yml uses the intended action tags and preserves workflow conditions and Jira commenting behavior.
  • Validate create_issue.yml uses the intended action tags and preserves Jira issue creation, GitHub issue updates, and comments.
  • Validate create_issue_on_label.yml uses the intended action tags and preserves label-triggered Jira synchronization.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Validate comment_issue.yml uses the intended action tags and preserves workflow conditions and Jira commenting behavior.
2. Validate create_issue.yml uses the intended action tags and preserves Jira issue creation, GitHub issue updates, and comments.
3. Validate create_issue_on_label.yml uses the intended action tags and preserves label-triggered Jira synchronization.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

if: github.event.label.name == env.JIRA_ISSUE_LABEL
id: login
uses: atlassian/gajira-login@90a599561baaf8c05b080645ed73db7391c246ed # v2.0.0
uses: atlassian/gajira-login@v2.0.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

Restore verified immutable commit-SHA pins for every third-party action in this workflow. Preserve the existing workflow logic and optionally retain human-readable version comments.

if: env.JIRA_CREATE_ISSUE_AUTO == 'true'
id: login
uses: atlassian/gajira-login@90a599561baaf8c05b080645ed73db7391c246ed # v2.0.0
uses: atlassian/gajira-login@v2.0.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

Restore verified full commit-SHA pins for every third-party action in this workflow rather than using mutable version tags. Retain version comments for auditability if desired.

if: env.JIRA_CREATE_COMMENT_AUTO == 'true'
id: github_issue_type
uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0
uses: actions/github-script@v2.0.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

Pin every third-party action in this workflow to a verified full commit SHA instead of a mutable tag. Preserve the human-readable version in a comment if needed, and leave the workflow behavior unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant