Repository navigation
Commit 9bd4a68
say which stable release this is the first of, and what #224 left behind
Two review points. The release-history line called v26.7.3 the first stable
release the binding has been pinned to, which reads past v26.7.0 -- that was
stable as well, and was the original V1 baseline. It is the first stable one
since the RC baseline.
The other asked for chdb_reset_signal_handlers() to check whether the handler
it is about to reset is still chDB's. The premise it argued from is the
pre-#224 code: v26.7.3 walks HandledSignals::handled_signals instead of a
fixed list of eight deadly signals, and returns before touching anything when
chDB installed no handler. But the narrower half of the point stands, because
that record holds signal numbers and not the disposition each signal had
before chDB replaced it, so the reset hands back SIG_DFL rather than the
host's previous handler. It cannot reach this driver -- the loader opts out
before the first connect, so the list is empty and the loop walks nothing,
measured as an empty reset set and zero exposures -- so it is recorded as the
gap that remains between chdb.h's contract and the code rather than acted on.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 9a71c8b commit 9bd4a68
1 file changed
Lines changed: 19 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
| 21 | + | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
173 | 190 | | |
174 | 191 | | |
175 | 192 | | |
| |||
0 commit comments