(chore): Use variable as bucket name in scripts by AkariiinMKII · Pull Request #1068 · chawyehsu/dorado

AkariiinMKII · 2026-09-30T16:43:11Z

Use variable as bucket name in scripts in case that users use custom naming for dorado bucket
Update checkver methods and versions for miniforge and neteasemusic

coderabbitai · 2026-09-30T16:52:42Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 607fbd2c-18c4-4769-9924-c2cabb107584

📥 Commits

Reviewing files that changed from the base of the PR and between dce1165 and a4718e5.

📒 Files selected for processing (1)

bucket/neteasemusic.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Summary by CodeRabbit

Bug Fixes
- Updated package setup and removal scripts to find support files in the configured bucket for affected packages. NetEase Cloud Music continues to use the Dorado bucket, while QQ Music uses its own bucket.
Updates
- Updated Miniforge to version 26.7.2-0 and NetEase Cloud Music to version 3.1.40.205461, including their download details.
- NetEase Cloud Music version checking now recognizes installer downloads for either supported architecture.

Walkthrough

Installer and uninstaller manifests change how they locate helper scripts and modules. Miniforge and NetEase Music also update release metadata and version detection.

Changes

Installer paths and manifest updates

Layer / File(s)	Summary
Resolve helper paths from bucket values `bucket/bee.json`, `bucket/bilibili.json`, `bucket/miniconda.json`, `bucket/msys2-cn.json`, `bucket/qqmusic.json`, `deprecated/clash-for-windows.json`	These manifests resolve helper scripts or modules using the current bucket value.
Update Miniforge release metadata `bucket/miniforge.json`	The version, 64-bit download URL and SHA-256 hash, helper module paths, and `checkver` value are updated.
Update NetEase Music release and version detection `bucket/neteasemusic.json`	The version, architecture-specific download URLs and hashes, module paths, and version detection request and regex are updated.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to a4718

Helper paths and Miniforge metadata are addressed. NetEase automatic version detection retains a bounded compatibility risk because some clients receive a 403 response without the filename.

Architecture Summary

Architecture risk: 🔵 Low · up to a4718

The change affects 2 systems.

Changed systems: bucket, deprecated

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — bucket (service) was modified; 7 changed files map to changed impact.
observed — deprecated (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in bucket/bee.json: The installer now locates beesvc.cmd under the current bucket directory instead of always looking under the dorado bucket.
observed — Modified behavior in bucket/bilibili.json: The installer’s module import now resolves DoradoUtils.psm1 from the current bucket rather than the hard-coded dorado bucket.
observed — Modified behavior in bucket/bilibili.json: The uninstaller’s module import now resolves DoradoUtils.psm1 from the current bucket rather than the hard-coded dorado bucket.
observed — Modified behavior in bucket/miniconda.json: The installer’s module path now uses $bucket instead of the hard-coded dorado bucket name.

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a80a06f6-6bbd-4abb-b17d-b6f7aaba23e5

📥 Commits

Reviewing files that changed from the base of the PR and between 3ee37c9 and c5baf8c.

📒 Files selected for processing (8)

bucket/bee.json
bucket/bilibili.json
bucket/miniconda.json
bucket/miniforge.json
bucket/msys2-cn.json
bucket/neteasemusic.json
bucket/qqmusic.json
deprecated/clash-for-windows.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

AkariiinMKII · 2026-09-30T16:52:48Z

/verify

github-actions · 2026-09-30T17:03:21Z

AkariiinMKII · 2026-10-01T14:19:47Z

/verify

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f526cc19-2bf8-4f81-ba80-72079493ccca

📥 Commits

Reviewing files that changed from the base of the PR and between c5baf8c and 0d0b947.

📒 Files selected for processing (2)

bucket/miniforge.json
bucket/neteasemusic.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 30986363-0068-4ceb-a437-11b824c9727b

📥 Commits

Reviewing files that changed from the base of the PR and between 0d0b947 and 769e041.

📒 Files selected for processing (1)

bucket/miniforge.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

github-actions · 2026-10-01T14:53:41Z

AkariiinMKII · 2026-10-01T15:02:16Z

/verify

github-actions · 2026-10-01T15:39:56Z

AkariiinMKII · 2026-10-01T15:51:11Z

/verify

github-actions · 2026-10-01T16:17:28Z

(chore): Use variable as bucket name in scripts

c5baf8c

AkariiinMKII requested a review from chawyehsu as a code owner September 30, 2026 16:43

coderabbitai Bot reviewed Sep 30, 2026

View reviewed changes

Comment thread bucket/bilibili.json Resolved

github-actions Bot added the manifest-fix-needed label Sep 30, 2026

coderabbitai Bot reviewed Oct 1, 2026

View reviewed changes

Comment thread bucket/neteasemusic.json Resolved

coderabbitai Bot reviewed Oct 1, 2026

View reviewed changes

Comment thread bucket/miniforge.json Resolved

AkariiinMKII force-pushed the update-bucket-name-in-scripts branch from dce1165 to 2b7ffec Compare October 1, 2026 15:27

AkariiinMKII added 2 commits October 1, 2026 15:29

neteasemusic: Update checkver method, update to version 3.1.40.205461

efc7f88

miniforge: Update checkver method, update to version 26.7.2-0

a4718e5

AkariiinMKII force-pushed the update-bucket-name-in-scripts branch from 2b7ffec to a4718e5 Compare October 1, 2026 15:29

github-actions Bot added review-needed and removed manifest-fix-needed labels Oct 1, 2026

Conversation

AkariiinMKII commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Summary by CodeRabbit

Walkthrough

Changes

Architecture Summary

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AkariiinMKII commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

bee

bilibili

miniconda

miniforge

msys2-cn

neteasemusic

qqmusic

Uh oh!

AkariiinMKII commented Oct 1, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2026

bee

bilibili

miniconda

miniforge

msys2-cn

neteasemusic

qqmusic

Uh oh!

AkariiinMKII commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

bee

bilibili

miniconda

miniforge

msys2-cn

neteasemusic

qqmusic

Uh oh!

AkariiinMKII commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

bee

bilibili

miniconda

miniforge

msys2-cn

neteasemusic

qqmusic

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

AkariiinMKII commented Sep 30, 2026 •

edited

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading