Skip to content

todesk: Update scripts for new file structures in app installer - #1050

Merged
chawyehsu merged 3 commits into
chawyehsu:masterfrom
AkariiinMKII:fix-todesk
Jul 6, 2026
Merged

chawyehsu merged 3 commits into
chawyehsu:masterfrom
AkariiinMKII:fix-todesk

Conversation

@AkariiinMKII

@AkariiinMKII AkariiinMKII commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor
  • Fix installer script error due to installer structures changing
  • Reorder fields according to the scoop guidelines

Open in Stage

@AkariiinMKII
AkariiinMKII requested a review from chawyehsu as a code owner July 6, 2026 06:57
@ghost

ghost commented Jul 6, 2026 •

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 1 individual chapter for you:

Title
1 Update installer script and reorder manifest fields
Open in Stage

Chapters generated by Stage for commit 3465abc on Jul 6, 2026 10:17am UTC.

@AkariiinMKII

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

todesk

  • Lint
  • Description
  • License

Check the full log for details.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026 •

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

bucket/todesk.json reorders manifest metadata and replaces separate install hooks with a single installer.script. The script selects the correct archive by architecture, expands it, removes installer artifacts, and conditionally creates config.ini with updated defaults.

Changes

Manifest Install Script Update

Layer / File(s) Summary
Unified installer script and metadata reorder
bucket/todesk.json
Reorders manifest metadata and replaces pre_install/post_install with installer.script that selects and expands the archive, cleans up old artifacts, and writes a default config.ini when absent.

Suggested labels: manifest-update, bucket

Suggested reviewers: chawyehsu


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AkariiinMKII
AkariiinMKII force-pushed the fix-todesk branch 2 times, most recently from 5f936b0 to 3465abc Compare July 6, 2026 10:17
@chawyehsu
chawyehsu merged commit 824528b into chawyehsu:master Jul 6, 2026
2 checks passed
@AkariiinMKII
AkariiinMKII deleted the fix-todesk branch July 6, 2026 15:18
@AkariiinMKII
AkariiinMKII restored the fix-todesk branch August 14, 2026 13:02
@AkariiinMKII
AkariiinMKII deleted the fix-todesk branch August 14, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants