From 17792c3f610302a9e9998264725d0480a2f24740 Mon Sep 17 00:00:00 2001 From: Amp Date: Sat, 8 Aug 2026 11:14:22 +0000 Subject: [PATCH] Downgrade Go 1.26.5 -> 1.25.12 to fix Windows exit-status flake Since the Go 1.26.5 bump (#4134, merge build 13445), Windows AMD64 CI has intermittently failed with: *os.SyscallError: GetExitCodeProcess: The handle is invalid. from Cmd.Wait after the process has exited. This matches the Cmd.Wait / watchCtx process-handle races tracked in golang/go#78046, whose fixes landed on master for Go 1.27 but have not been backported to 1.26.x. Go 1.26 introduced new process-handle lifetime machinery in os/exec that is consistent with this failure mode; Go 1.25 does not have it. Downgrade to Go 1.25.12 (current supported patch release of the 1.25 line) as a stopgap. We should re-upgrade directly to Go 1.27 once it is released with the golang/go#78046 fixes. Amp-Thread-ID: https://ampcode.com/threads/T-019fe0a2-982c-74fa-830c-5aa0c249369e Co-authored-by: Lachlan Donald --- .buildkite/Dockerfile-compile | 2 +- .buildkite/Dockerfile-e2e | 2 +- go.mod | 2 +- mise.toml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.buildkite/Dockerfile-compile b/.buildkite/Dockerfile-compile index 4d643fcbe2..0da13fbcfd 100644 --- a/.buildkite/Dockerfile-compile +++ b/.buildkite/Dockerfile-compile @@ -1,4 +1,4 @@ -FROM public.ecr.aws/docker/library/golang:1.26.5@sha256:3aff6657219a4d9c14e27fb1d8976c49c29fddb70ba835014f477e1c70636647 +FROM public.ecr.aws/docker/library/golang:1.25.12@sha256:fe5d57d3b718e7a4986bae156c2d73f44973bfd313073aed08a4de6692bb6161 COPY build/ssh.conf /etc/ssh/ssh_config.d/ RUN go install github.com/google/go-licenses@latest diff --git a/.buildkite/Dockerfile-e2e b/.buildkite/Dockerfile-e2e index 3e19d93f06..59a462b418 100644 --- a/.buildkite/Dockerfile-e2e +++ b/.buildkite/Dockerfile-e2e @@ -1,4 +1,4 @@ -FROM public.ecr.aws/docker/library/golang:1.26.5@sha256:3aff6657219a4d9c14e27fb1d8976c49c29fddb70ba835014f477e1c70636647 +FROM public.ecr.aws/docker/library/golang:1.25.12@sha256:fe5d57d3b718e7a4986bae156c2d73f44973bfd313073aed08a4de6692bb6161 RUN apt-get update && apt-get install -y --no-install-recommends \ unzip \ diff --git a/go.mod b/go.mod index a41a6c83c0..e9f8d8e1aa 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/buildkite/agent/v4 -go 1.26.5 +go 1.25.12 require ( buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.36.11-20260709200747-435963d16310.1 diff --git a/mise.toml b/mise.toml index 39bc7047eb..b14a5e1727 100644 --- a/mise.toml +++ b/mise.toml @@ -1,5 +1,5 @@ [tools] -go = "1.26.5" +go = "1.25.12" golangci-lint = "2.9.0" ruby = "3.4.9"