Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10504 +/- ##
==========================================
+ Coverage 89.12% 89.13% +0.01%
==========================================
Files 103 103
Lines 19783 19868 +85
Branches 3099 3115 +16
==========================================
+ Hits 17631 17710 +79
- Misses 1490 1497 +7
+ Partials 662 661 -1 ☔ View full report in Codecov by Harness. |
…orgbackup#10025 Archive check results are kept in cache/checked-archives, refs borgbackup#10356.
mr-raj12
force-pushed
the
check-archives-tracking-10025
branch
from
October 6, 2026 19:48
253f5da to
f0de2d7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10025, refs #10356. Implements what was agreed in #10025 (comment).
borg checknow records the result of the archives check per archive incache/checked-archives(archive id -> timestamp, result), in the same format and envelope ascache/checked-packs.--max-agealso skips archives whose ok record is younger than the timespan, and is allowed with--archives-only.--repairand--verify-datacheck every archive.--max-durationis one time budget for the repository check and the archives check, and no longer requires--repository-only. The archives check takes the archives without an ok record first, then the least recently checked ones, and stops between two archives after it analyzed at least one.--repair.Commits:
repository: split CheckTracker out of PackTracker: refactoring only, no behavior change.check: --max-age and --max-duration cover the archives check: the feature, tests and docs.Decisions that go beyond the issue discussion, please object if you disagree:
checked-packs, and when a run without--repairhas a finding before it analyzes the archives (missing pack, dropped content,--verify-dataor--find-lost-archiveserror).--max-duration, the archives check is skipped with an info message. Without--max-age, a repository check that never finishes within the budget therefore never lets the archives check run. The help text says so and suggests--max-ageor separate--repository-only/--archives-onlyruns.--archives-only --max-durationmakes progress in every run.--max-durationis rejected with--verify-dataand--find-lost-archives, as both scan the whole repository.cache/(BORG_REPO_PERMISSIONS=read-only) can still runcheck --archives-only, it logs a warning and stores no records.Timing, 10 archives of 100k files each, aes256-ocb, local repository:
check --archives-onlycheck --archives-only --max-age=1dcheck --max-age=1dcheck --repository-onlycheck --archives-only --max-duration=3docs/changes.rstand the generated usage docs are not touched. This touches the same files as #10194 and #9891, I will rebase when needed.Checklist
master(or maintenance branch if only applicable there)toxor the relevant test subset)