Add empty name validation - #358
Closed
mendral-app[bot] wants to merge 1 commit into
Closed
Conversation
Add a check for empty string when no type prefix is given, preventing invalid API calls with an empty target_name. Previously, an empty argument would pass through to the API which returned a 400 error.
Contributor
|
Closing this and every other open mendral dependency PR on the org. These had accumulated to ~425 across 50+ repos, most of them superseded by a later run of the same weekly job, and a large share already in merge conflict. As a queue they were never going to be merged, and they were burying the alerts that actually matter under review noise. Nothing is lost by closing them: the open Dependabot alerts remain the source of truth, and remediation is being done through dedicated, tested PRs per repo instead of bulk updates. Anything still genuinely vulnerable will be fixed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseForkArgwhen no type prefix is given, so the CLI returns a clear error instead of sending an invalid request to the APIFixes the issue where
bl fork <source> ""would pass through to the API and receive a 400 "fork target name is required" error.Related insight: https://app.mendral.com/insights/01KYNFVYW75N4R95F28CW6XXED
Note
Created by Mendral. Tag @mendral-app with feedback or questions.