Skip to content

Another round of refactoring? #94

Description

@sajith

Just writing down some thoughts, so this could be a meta-issue:

  • The topology and connection request generators do not have be in classes. They could be "bare" functions (no state to keep around, and easier to reason about), and they could live in a utils.generators module, so we'd use them like:
from sdx.pce.utils.generators import make_random_toplogy, make_random_connection_request
  • TE solver could be in a solvers module so we'd use it like:
from sdx.pce.solvers.te_solver import TESolver

The solver also could probably become a bare function: solve_te() maybe (for lack of a better name), unless we have a reason to have to keep some state around.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions