From 33f30775404bae8009d9cadc7bf07a782040efa3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Ferreira?= Date: Thu, 26 Sep 2024 00:41:19 +0100 Subject: [PATCH 1/5] configure aws-spi-pekko-http integration tests in nightly builds --- .github/workflows/nightly-builds.yaml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/nightly-builds.yaml b/.github/workflows/nightly-builds.yaml index 8d2444fb1..8adadad5a 100644 --- a/.github/workflows/nightly-builds.yaml +++ b/.github/workflows/nightly-builds.yaml @@ -56,12 +56,14 @@ jobs: - name: Cache Coursier cache uses: coursier/cache-action@v6 - - name: S3 Integration tests + - name: AWS connectors Integration tests + env: + AWS_ACCESS_KEY: ${{ secrets.AWS_ACCESS_KEY }} + AWS_SECRET_KEY: ${{ secrets.AWS_SECRET_KEY }} run: |- sbt \ - -Dpekko.connectors.s3.aws.credentials.provider=static \ - -Dpekko.connectors.s3.aws.credentials.access-key-id=${{ secrets.AWS_ACCESS_KEY }} \ - -Dpekko.connectors.s3.aws.credentials.secret-access-key=${{ secrets.AWS_SECRET_KEY }} \ -Dpekko.stream.connectors.s3.scaladsl.AWSS3IntegrationSpec.enableListAllMyBucketsTests=false \ -Dpekko.stream.connectors.s3.scaladsl.AWSS3IntegrationSpec.enableMFATests=false \ + "s3/Test/runMain org.scalatest.tools.Runner -o -s org.apache.pekko.stream.connectors.s3.scaladsl.AWSS3IntegrationSpec" + sbt \ + + "aws-spi-pekko-http/it:test" From 2622799d0da8ba172909d43869725950ceb7b5ce Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Thu, 26 Sep 2024 10:22:01 +0100 Subject: [PATCH 2/5] temp enable run for related PR to test in CI --- .github/workflows/nightly-builds.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/nightly-builds.yaml b/.github/workflows/nightly-builds.yaml index 8adadad5a..13a1d5a87 100644 --- a/.github/workflows/nightly-builds.yaml +++ b/.github/workflows/nightly-builds.yaml @@ -4,6 +4,7 @@ on: schedule: - cron: "0 3 * * *" workflow_dispatch: + pull_request: permissions: {} From 3f8341641dfe17f7603902f03d7f026b115de072 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Ferreira?= Date: Thu, 26 Sep 2024 10:40:13 +0100 Subject: [PATCH 3/5] Update .github/workflows/nightly-builds.yaml --- .github/workflows/nightly-builds.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-builds.yaml b/.github/workflows/nightly-builds.yaml index 13a1d5a87..307379515 100644 --- a/.github/workflows/nightly-builds.yaml +++ b/.github/workflows/nightly-builds.yaml @@ -59,7 +59,7 @@ jobs: - name: AWS connectors Integration tests env: - AWS_ACCESS_KEY: ${{ secrets.AWS_ACCESS_KEY }} + AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY }} AWS_SECRET_KEY: ${{ secrets.AWS_SECRET_KEY }} run: |- sbt \ From e881f6091f54fd68b6cfd0167eec43a57d0b1535 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Thu, 26 Sep 2024 11:06:39 +0100 Subject: [PATCH 4/5] try AWS_SECRET_ACCESS_KEY --- .github/workflows/nightly-builds.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-builds.yaml b/.github/workflows/nightly-builds.yaml index 307379515..915d409f3 100644 --- a/.github/workflows/nightly-builds.yaml +++ b/.github/workflows/nightly-builds.yaml @@ -60,7 +60,7 @@ jobs: - name: AWS connectors Integration tests env: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY }} - AWS_SECRET_KEY: ${{ secrets.AWS_SECRET_KEY }} + AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_KEY }} run: |- sbt \ -Dpekko.stream.connectors.s3.scaladsl.AWSS3IntegrationSpec.enableListAllMyBucketsTests=false \ From ab86f09920dc24e981dd6c17e6e40a189d698e26 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Ferreira?= Date: Thu, 26 Sep 2024 11:45:22 +0100 Subject: [PATCH 5/5] revert changes to Integration tests step to make sure secrets are still passed... --- .github/workflows/nightly-builds.yaml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/nightly-builds.yaml b/.github/workflows/nightly-builds.yaml index 915d409f3..5fc848fe1 100644 --- a/.github/workflows/nightly-builds.yaml +++ b/.github/workflows/nightly-builds.yaml @@ -57,14 +57,12 @@ jobs: - name: Cache Coursier cache uses: coursier/cache-action@v6 - - name: AWS connectors Integration tests - env: - AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY }} - AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_KEY }} + - name: S3 Integration tests run: |- sbt \ + -Dpekko.connectors.s3.aws.credentials.provider=static \ + -Dpekko.connectors.s3.aws.credentials.access-key-id=${{ secrets.AWS_ACCESS_KEY }} \ + -Dpekko.connectors.s3.aws.credentials.secret-access-key=${{ secrets.AWS_SECRET_KEY }} \ -Dpekko.stream.connectors.s3.scaladsl.AWSS3IntegrationSpec.enableListAllMyBucketsTests=false \ -Dpekko.stream.connectors.s3.scaladsl.AWSS3IntegrationSpec.enableMFATests=false \ + "s3/Test/runMain org.scalatest.tools.Runner -o -s org.apache.pekko.stream.connectors.s3.scaladsl.AWSS3IntegrationSpec" - sbt \ - + "aws-spi-pekko-http/it:test"