From 8d92089b3896bb0c4b70d04f49543239bfdf6e7e Mon Sep 17 00:00:00 2001 From: Walter Duque de Estrada Date: Mon, 20 Jul 2026 12:46:17 -0500 Subject: [PATCH] test(grails-data-hibernate7): re-enable Oracle in the RLikeHibernate7Spec dialect matrix Oracle Testcontainers has historically been flaky enough in CI that this row was disabled. Re-evaluating now: gvenzl/oracle-free:slim-faststart ships native ARM64 + x86_64 images (no more x86-under-emulation startup penalty on Apple Silicon), and ran to "DATABASE IS READY TO USE!" in ~13s locally on repeated runs. Adds an explicit 3-minute startup timeout as a safety margin against the known too-tight default (testcontainers/testcontainers-java#9057) without slowing down the common case. This is test-only, no production code changes - if Oracle proves flaky again in real CI (particularly on shared/loaded runners, which this local run can't represent), the row can be dropped again. Co-Authored-By: Claude Sonnet 5 --- .../groovy/grails/gorm/tests/RLikeHibernate7Spec.groovy | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/RLikeHibernate7Spec.groovy b/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/RLikeHibernate7Spec.groovy index 88409b030a5..9af168a42bc 100644 --- a/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/RLikeHibernate7Spec.groovy +++ b/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/RLikeHibernate7Spec.groovy @@ -28,6 +28,8 @@ import spock.lang.Requires import spock.lang.Shared import spock.lang.Unroll +import java.time.Duration + @Testcontainers @Requires({ isDockerAvailable() }) class RLikeHibernate7Spec extends HibernateGormDatastoreSpec { @@ -35,7 +37,12 @@ class RLikeHibernate7Spec extends HibernateGormDatastoreSpec { @Shared postgres = new PostgreSQLContainer("postgres:16") @Shared mysql = new MySQLContainer("mysql:8.0") @Shared mariadb = new MariaDBContainer("mariadb:10.11") + // slim-faststart ships native ARM64 + x86_64 images and typically reports ready in ~15s, + // but the default 60s Testcontainers timeout has been too tight on loaded/emulated CI + // runners (testcontainers/testcontainers-java#9057) - a generous explicit timeout avoids + // that without slowing down the common case. @Shared oracle = new OracleContainer("gvenzl/oracle-free:slim-faststart") + .withStartupTimeout(Duration.ofMinutes(3)) void setupSpec() { manager.registerDomainClasses(RlikeFoo) @@ -84,7 +91,7 @@ class RLikeHibernate7Spec extends HibernateGormDatastoreSpec { "Postgres" | postgres "MySQL" | mysql "MariaDB" | mariadb - // "Oracle" | oracle + "Oracle" | oracle } }