You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#3678. znormalized=True meant input is already normalized (skip normalization), which is confusing since True reads as 'yes, normalize'. Added znormalize (default True, means 'do normalize') as the new parameter. znormalized is kept for backward compatibility with default sentinel 'deprecated', emits a FutureWarning when explicitly passed, and is internally mapped to the equivalent znormalize value (note the meaning is inverted: znormalized=True == znormalize=False).
Updated the one internal caller in _redcomets.py to use znormalize=False (behavior-preserving equivalent of its old znormalized=True call). Updated docstrings and the SAX.inverse_sax error message wording. Updated the existing test asserting the old default (test_sax_default_znormalized_is_true) to reflect the new default, and added a new test for the deprecation warning + value mapping.
Verified: full test_sax.py suite (48 tests) and both redcomets test files pass. Also ran a standalone check that get_params()/clone() still round-trip correctly for both the new and legacy parameter, per sklearn's estimator contract.
I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ classification, transformations ]. Feel free to change these if they do not properly represent the PR.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit code quality check fails, please run pre-commit locally and push the fixes to your PR branch.
Don't hesitate to ask questions on the aeonDiscord channel if you have any.
PR CI actions
These checkboxes will add labels to enable or disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
Yes this is a duplicate, and runs into the same issue as previous. See the review and functionality changes requested in #3680 if you wish to proceed please. This is more then a rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aeon-actions-bot
Bot
added
classification
Fixes #3678. znormalized=True meant input is already normalized (skip normalization), which is confusing since True reads as 'yes, normalize'. Added znormalize (default True, means 'do normalize') as the new parameter. znormalized is kept for backward compatibility with default sentinel 'deprecated', emits a FutureWarning when explicitly passed, and is internally mapped to the equivalent znormalize value (note the meaning is inverted: znormalized=True == znormalize=False).
Updated the one internal caller in _redcomets.py to use znormalize=False (behavior-preserving equivalent of its old znormalized=True call). Updated docstrings and the SAX.inverse_sax error message wording. Updated the existing test asserting the old default (test_sax_default_znormalized_is_true) to reflect the new default, and added a new test for the deprecation warning + value mapping.
Verified: full test_sax.py suite (48 tests) and both redcomets test files pass. Also ran a standalone check that get_params()/clone() still round-trip correctly for both the new and legacy parameter, per sklearn's estimator contract.