Skip to content

🎨 Palette: improve copy feedback and button accessibility in DevTools - #5

Closed
Xp-boss wants to merge 1 commit into
mainfrom
palette-devtools-copy-feedback-10631533765625514172
Closed

Xp-boss wants to merge 1 commit into
mainfrom
palette-devtools-copy-feedback-10631533765625514172

Conversation

@Xp-boss

@Xp-boss Xp-boss commented Nov 2, 2026

Copy link
Copy Markdown
Owner

💡 What:

  • Added temporary visual copy feedback (checkmark state with green highlight for 2 seconds) and updated title/aria-label when copying JSON in DevTools payload/response views.
  • Added aria-label and aria-pressed to icon-only buttons in the DevTools UI (theme toggle, group by domain, and download JSON).
  • Ensured timeout cleanup on component unmount to prevent memory leaks.

🎯 Why:

  • The "Copy JSON" button previously had no visual indication when clicked, leaving users unsure if the copy succeeded.
  • Icon-only buttons lacked accessible names for screen readers (aria-label) and state indicators (aria-pressed).

♿ Accessibility:

  • Added aria-label="Copy JSON" (updating to "Copied to clipboard" upon copying) and aria-label="Download JSON" to payload action buttons.
  • Added descriptive aria-label and toggle state to the theme toggle button and "Group by domain" button.

PR created automatically by Jules for task 10631533765625514172 started by @Xp-boss

Add visual copy confirmation with checkmark state and accessible labels to DevTools toolbar buttons.

Co-authored-by: Xp-boss <67393766+Xp-boss@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the size/M M: 50-249 lines changed label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

📊 PR Size: size/M

  • Lines changed: 56
  • Additions: +47
  • Deletions: -9
  • Files changed: 2

@Xp-boss

Xp-boss commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Closing as a duplicate of #8 — this is the same Palette DevTools change to packages/devtools/client/src/App.tsx. Keeping #8 as the single version, which is being submitted upstream. The branch is kept, so this can be reopened if needed.

@Xp-boss Xp-boss closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M M: 50-249 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant