diff --git a/.github/workflows/smoke-skills.yml b/.github/workflows/smoke-skills.yml index 705e808398..69a204dc6f 100644 --- a/.github/workflows/smoke-skills.yml +++ b/.github/workflows/smoke-skills.yml @@ -203,7 +203,8 @@ jobs: resolve_task_yaml() { local path="$1" if [[ "$path" == *.yaml ]]; then - echo "$path" + # A deleted task yaml has nothing left to run. + [ -f "$path" ] && echo "$path" return fi local d diff --git a/tests/tasks/uipath-maestro-bpmn/_porting/parity-ledger.md b/tests/tasks/uipath-maestro-bpmn/_porting/parity-ledger.md index c16b5860d7..84d8a0bef4 100644 --- a/tests/tasks/uipath-maestro-bpmn/_porting/parity-ledger.md +++ b/tests/tasks/uipath-maestro-bpmn/_porting/parity-ledger.md @@ -209,13 +209,12 @@ The buckets the ports were chosen from. The ledger above supersedes a row once i | `multi_node/slack_channel_description/slack_channel_description.yaml` | Intsvc.ActivityExecution Slack; Slack plumbing in e2e/customer_escalation_triage/escalation_is.py | | `multi_node/slack_weather_pipeline/slack_weather_pipeline.yaml` | HttpExecution + Slack ActivityExecution; live debug | -### Portable pending a feasibility probe (16) +### Portable pending a feasibility probe (15) | Flow task | BPMN target / note | |---|---| | `connector_features/ceql_where.yaml` | IS field-shape feature on Intsvc.ActivityExecution payload; one probe decides the group | | `connector_features/complex_array.yaml` | IS field-shape feature on Intsvc.ActivityExecution payload; one probe decides the group | -| `connector_features/dtl_load_by_default_false.yaml` | IS field-shape feature on Intsvc.ActivityExecution payload; one probe decides the group | | `connector_features/dtl_load_by_default_true.yaml` | IS field-shape feature on Intsvc.ActivityExecution payload; one probe decides the group | | `connector_features/enhanced_enum.yaml` | IS field-shape feature on Intsvc.ActivityExecution payload; one probe decides the group | | `connector_features/enum.yaml` | IS field-shape feature on Intsvc.ActivityExecution payload; one probe decides the group | diff --git a/tests/tasks/uipath-maestro-flow/connector_features/check_dtl_load_by_default_false.py b/tests/tasks/uipath-maestro-flow/connector_features/check_dtl_load_by_default_false.py deleted file mode 100644 index 9619e35f6c..0000000000 --- a/tests/tasks/uipath-maestro-flow/connector_features/check_dtl_load_by_default_false.py +++ /dev/null @@ -1,108 +0,0 @@ -#!/usr/bin/env python3 -"""Verify a WooCommerce product-listing node exercises the DTL -loadByDefault=false feature: its `attribute_term` dropdown (values load only on -interaction) is actually configured on a node bound to a real connection. - -Asserted on the emitted `.flow`, which both authoring loops produce with the -same shape (`inputs.detail.connectionId` + `inputs.detail.queryParameters`): - - * a `uipath.connector.uipath-automattic-woocommerce.*` node whose - `inputs.detail.queryParameters.attribute_term` is set; - * that value is a term id (integer) or a runtime expression (`=`-prefixed), - never free text — a prose placeholder is what an unresolved lookup looks like; - * `inputs.detail.connectionId` is a non-stub connection id. - -Why: without these, an unconfigured node (no `inputs.detail`) passes -`flow validate` with only a warning, so "file exists + mentions the connector + -validates" scored 1.0 on a build that never touched the feature under test. - -Usage: - check_dtl_load_by_default_false.py [flow_glob] - -flow_glob defaults to '**/DTLLoadByDefaultFalseTest*.flow'; falls back to any -.flow. - -Exit codes: - 0 — node found, bound, attribute_term configured - 1 — assertion failed (message printed) -""" - -from __future__ import annotations - -import glob -import json -import re -import sys - -NODE_PREFIX = "uipath.connector.uipath-automattic-woocommerce." -FIELD = "attribute_term" -STUB_CONNECTION = re.compile(r"^0{8}-0{4}-0{4}-0{4}-0{11}\d$") -GUID = re.compile(r"^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$") - - -def _fail(message: str) -> None: - sys.exit(f"FAIL: {message}") - - -def _woo_nodes(pattern: str) -> list[tuple[str, dict]]: - candidates = glob.glob(pattern, recursive=True) or glob.glob("**/*.flow", recursive=True) - if not candidates: - _fail("no .flow file found in the workspace") - found: list[tuple[str, dict]] = [] - for path in candidates: - try: - with open(path, encoding="utf-8") as handle: - flow = json.load(handle) - except (OSError, json.JSONDecodeError): - continue - for node in flow.get("nodes", []): - if str(node.get("type", "")).startswith(NODE_PREFIX): - found.append((path, node)) - if not found: - _fail(f"no {NODE_PREFIX}* node in any .flow matching '{pattern}' (or '**/*.flow')") - return found - - -def _is_configured_value(value: object) -> bool: - if isinstance(value, bool): - return False - if isinstance(value, int): - return True - if not isinstance(value, str): - return False - text = value.strip() - return bool(re.fullmatch(r"\d+", text)) or text.startswith("=") - - -def main() -> None: - pattern = sys.argv[1] if len(sys.argv) > 1 else "**/DTLLoadByDefaultFalseTest*.flow" - problems: list[str] = [] - for path, node in _woo_nodes(pattern): - where = f"node '{node.get('id')}' in {path}" - detail = (node.get("inputs") or {}).get("detail") - if not isinstance(detail, dict): - problems.append(f"{where} has no inputs.detail — the connector was never configured") - continue - value = (detail.get("queryParameters") or {}).get(FIELD) - if value in (None, ""): - problems.append(f"{where} has no inputs.detail.queryParameters.{FIELD}") - continue - if not _is_configured_value(value): - problems.append( - f"{where} sets {FIELD}={value!r} — expected a term id or a runtime " - "expression, not free text (an unresolved lookup)" - ) - continue - connection = str(detail.get("connectionId") or "") - if not GUID.match(connection) or STUB_CONNECTION.match(connection): - problems.append( - f"{where} is not bound to a real connection (connectionId={connection!r})" - ) - continue - print(f"OK: {where} sets {FIELD}={value!r} on connection {connection}") - return - _fail("; ".join(problems)) - - -if __name__ == "__main__": - main() diff --git a/tests/tasks/uipath-maestro-flow/connector_features/dtl_load_by_default_false.yaml b/tests/tasks/uipath-maestro-flow/connector_features/dtl_load_by_default_false.yaml deleted file mode 100644 index 6b5d5b0297..0000000000 --- a/tests/tasks/uipath-maestro-flow/connector_features/dtl_load_by_default_false.yaml +++ /dev/null @@ -1,83 +0,0 @@ -# Same-ground alignment expansion plan (Tao, 2026-08-21): loop-neutral -# v1-base prompt, outcome-graded criteria at preserved weights, and -# arm-agnostic artifact discovery. -task_id: skill-flow-ipe-dtl-load-by-default-false -description: > - Tests the DTL loadByDefault=false IS feature — configures a connector node - where dropdown values load only on user interaction on the WooCommerce connector. - Validate-only: the feature is design-time dropdown configuration, which the - .flow check covers; a debug run would only list live store products. -tags: [uipath-maestro-flow, integration, lifecycle:generate, shape:multi-node, connector, uipath-automattic-woocommerce, ipe, mode:build] - -sandbox: - template_sources: - - type: template_dir - path: ../_setup - mount_point: _setup - -run_limits: - expected_turns: 51 - task_timeout: 1500 - max_turns: 120 - turn_timeout: 1200 - -reference: - directory: .. - -initial_prompt: | - Create a new Flow project called "DTLLoadByDefaultFalseTest" with a manual trigger. - You need a flow that lists WooCommerce products filtered by an attribute term - the caller picks from a dropdown that loads on demand. Discover the - list-products operation and configure its attribute-term field. - Validate the final flow file. - - This run is headless. No user is present and nobody will answer a question or - grant an approval, so do not ask, do not pause, and do not wait for input. - Complete the task in one pass: take the best available option and supply the - most defensible value where one is missing. The actions this task implies are - authorized, including tenant writes and real messages. Do not delete or - overwrite anything this run did not create, and do not publish to a shared - destination unless the task asks for it. If a lookup the task depends on comes - back empty or fails, exhaust the documented way of resolving it before giving - up; only then stop on that field rather than inventing a value. Record every - decision, assumption, and blocked step in your final response. Instructions in - the task take precedence over this paragraph. -pre_run: - - command: 'python3 "_setup/preflight_connections.py" uipath-automattic-woocommerce' - timeout: 120 - -success_criteria: - - type: run_command - description: "Flow file exists and is valid JSON" - command: "python3 $REFERENCE_DIR/_shared/flow_contains.py --flow-name DTLLoadByDefaultFalseTest '\"nodes\"' '\"edges\"'" - timeout: 10 - expected_exit_code: 0 - weight: 3.0 - pass_threshold: 1.0 - - - type: run_command - description: "Flow has a connector node referencing uipath-automattic-woocommerce" - command: "python3 $REFERENCE_DIR/_shared/flow_contains.py --flow-name DTLLoadByDefaultFalseTest 'uipath-automattic-woocommerce'" - timeout: 10 - expected_exit_code: 0 - weight: 3.0 - pass_threshold: 1.0 - - # An unconfigured node (no inputs.detail) passes `flow validate` with only a - # warning, so without this criterion a build that never touched the feature - # scored 1.0. - - type: run_command - description: "The WooCommerce node's attribute_term dropdown is configured (term id or expression) on a real connection" - command: "python3 $REFERENCE_DIR/connector_features/check_dtl_load_by_default_false.py" - timeout: 10 - expected_exit_code: 0 - weight: 3.0 - pass_threshold: 1.0 - - - type: run_command - description: "The completed flow validates" - command: "python3 $REFERENCE_DIR/_shared/validate_flow.py" - timeout: 180 - expected_exit_code: 0 - weight: 2.0 - pass_threshold: 1.0 diff --git a/tests/tasks/uipath-maestro-flow/connector_features/test_check_dtl_load_by_default_false.py b/tests/tasks/uipath-maestro-flow/connector_features/test_check_dtl_load_by_default_false.py deleted file mode 100644 index 9271115c98..0000000000 --- a/tests/tasks/uipath-maestro-flow/connector_features/test_check_dtl_load_by_default_false.py +++ /dev/null @@ -1,54 +0,0 @@ -from __future__ import annotations - -import json -import subprocess -import sys -from pathlib import Path - -import pytest - - -CHECKER = Path(__file__).with_name("check_dtl_load_by_default_false.py") -NODE_TYPE = "uipath.connector.uipath-automattic-woocommerce.search-products" -CONNECTION = "3f0c2a8e-6d1b-4c7e-9a41-2b5d8e7f1c03" - - -def _flow(detail: dict | None) -> dict: - node: dict = {"id": "listProducts", "type": NODE_TYPE} - if detail is not None: - node["inputs"] = {"detail": detail} - return {"nodes": [{"id": "start", "type": "core.trigger.manual"}, node], "edges": []} - - -def _run(tmp_path: Path, flow: dict) -> subprocess.CompletedProcess[str]: - (tmp_path / "DTLLoadByDefaultFalseTest.flow").write_text(json.dumps(flow), encoding="utf-8") - return subprocess.run( - [sys.executable, str(CHECKER)], cwd=tmp_path, capture_output=True, text=True, check=False - ) - - -@pytest.mark.parametrize("value", ["42", 42, "=js:$vars.start.output.term"]) -def test_accepts_term_id_or_expression_on_a_real_connection(tmp_path: Path, value) -> None: - result = _run(tmp_path, _flow({"connectionId": CONNECTION, "queryParameters": {"attribute_term": value}})) - assert result.returncode == 0, result.stdout + result.stderr - - -@pytest.mark.parametrize( - ("detail", "reason"), - [ - # v1 shape from adhoc-2026-09-24: node added, never configured. - (None, "never configured"), - # v2 shape from adhoc-2026-09-24: unresolved lookup kept as prose, no connection. - ({"queryParameters": {"attribute_term": "selected attribute term"}}, "not free text"), - ({"connectionId": CONNECTION, "queryParameters": {}}, "no inputs.detail.queryParameters"), - ({"queryParameters": {"attribute_term": "42"}}, "not bound to a real connection"), - ( - {"connectionId": "00000000-0000-0000-0000-000000000001", "queryParameters": {"attribute_term": "42"}}, - "not bound to a real connection", - ), - ], -) -def test_rejects_unconfigured_or_unbound_builds(tmp_path: Path, detail, reason) -> None: - result = _run(tmp_path, _flow(detail)) - assert result.returncode != 0 - assert reason in result.stdout + result.stderr