Port: list every Spanish jump gate destination (#80)

The Spanish jump gate menus (map/f/f04/f04_5.stb twice and
map/s/s30/s30_5.stb) put East and West on one line, "Puerta de salto
Este -- Oeste", so they list one destination fewer than the script
offers: the last choice is blank, and the choices after North take the
player one destination further than they say. script_text gives the
three menus one line per destination, as in the English menu, and names
the time gate "Puerta del tiempo" as the Spanish text does elsewhere:

  Puerta de salto Norte
  Puerta de salto Este
  Puerta de salto Oeste
  Enfrente de la Puerta del tiempo
  Puente de Paznos (first f04 menu only)

Tests check the line counts and widths, and the extracted scripts when
DC2_DATA has them.

Author: drkm9743

docs/PC.md

@@ -496,6 +496,13 @@ Sphere turn black, a colour it never takes. The same file corrects those three
 lines by their exact text: "Tienes que acordarte de otra cosa más.", "De azul a
 rojo, de rojo a azul." and "...y cambiará el color.".
 
+The Spanish jump gate menus in Gundorada (`map/f/f04/f04_5.stb` and
+`map/s/s30/s30_5.stb`) put East and West on one line, "Puerta de salto Este --
+Oeste", so they show one destination fewer than the script offers: the last
+choice is blank and the ones after North lead one destination further than they
+say. The same file gives the three menus the English menu's lines, with East and
+West apart and the time gate named "Puerta del tiempo".
+
 ### darkchronicle
 
 ```

port/src/script_text.cpp

@@ -66,6 +66,35 @@ constexpr std::array<Line, 19> kS17Spanish{
      }
 };
 
+// The Spanish jump gate menus (maps f04 and s30) put East and West on one line, "Puerta de salto Este --
+// Oeste", so they list one destination fewer than the script offers: the last choice is blank and the
+// ones after North take the player one destination further than they say. They get the English menu's
+// lines, with the time gate named as the Spanish text names it elsewhere.
+constexpr std::array<Line, 2> kF04Spanish{
+    {
+     {0x2CD20,
+         "Selecciona Destino de la Puerta de salto\nPuerta de salto Norte\nPuerta de salto Este -- Oeste\nEnfrente de la Puerta de "
+         "salto\nPuente de Paznos",
+         "Selecciona Destino de la Puerta de salto\nPuerta de salto Norte\nPuerta de salto Este\nPuerta de salto Oeste\nEnfrente de "
+         "la Puerta del tiempo\nPuente de Paznos"},
+     {0x2CD98,
+         "Selecciona Destino de la Puerta de salto\nPuerta de salto Norte\nPuerta de salto Este -- Oeste\nEnfrente de la Puerta de "
+         "salto\n",
+         "Selecciona Destino de la Puerta de salto\nPuerta de salto Norte\nPuerta de salto Este\nPuerta de salto Oeste\nEnfrente de "
+         "la Puerta del tiempo"},
+     }
+};
+
+constexpr std::array<Line, 1> kS30Spanish{
+    {
+     {0x2FC94,
+         "Selecciona Destino de la Puerta de salto\nPuerta de salto Norte\nPuerta de salto Este -- Oeste\nEnfrente de la Puerta de "
+         "salto\n",
+         "Selecciona Destino de la Puerta de salto\nPuerta de salto Norte\nPuerta de salto Este\nPuerta de salto Oeste\nEnfrente de "
+         "la Puerta del tiempo"},
+     }
+};
+
 // The Spanish text of the Spheda lesson (event e314) says there is nothing more to remember right before
 // the colour rules, and gives a Sphere a black colour it never takes: it turns from blue to red and from
 // red to blue. The event files are Latin-1.
@@ -93,9 +122,11 @@ struct Script {
     std::span<const Line> lines;
 };
 
-constexpr std::array<Script, 1> kScripts{
+constexpr std::array<Script, 3> kScripts{
     {
      {"map/s/s17/s17_5.stb", kS17Spanish},
+     {"map/f/f04/f04_5.stb", kF04Spanish},
+     {"map/s/s30/s30_5.stb", kS30Spanish},
      }
 };
 

port/src/script_text.hpp

@@ -11,8 +11,10 @@
 // that shows it, the retail text it must find there and the text that replaces it. A replacement that
 // fits is written over the retail string; a longer one is appended after the script and the instruction
 // is pointed at it, so the file grows by Extra(key). A script that does not show every retail line is
-// left unchanged. The Spanish text of the Spheda lesson event (event/e300/e314/e314_5.txt) gets three
-// mistranslated lines corrected, each found by its exact text.
+// left unchanged. The Spanish jump gate menus of maps f04 and s30, which put East and West on one line
+// and so list a destination fewer than the script offers, get one line per destination the same way.
+// The Spanish text of the Spheda lesson event (event/e300/e314/e314_5.txt) gets three mistranslated
+// lines corrected, each found by its exact text.
 
 namespace script_text {
 

port/src/tests/script_text_test.cpp

@@ -1,14 +1,17 @@
 #include <gtest/gtest.h>
 
 #include <algorithm>
+#include <array>
 #include <cstdint>
 #include <cstdlib>
 #include <cstring>
 #include <filesystem>
 #include <fstream>
 #include <iterator>
+#include <span>
 #include <string>
 #include <string_view>
+#include <utility>
 #include <vector>
 
 #include "runscript.hpp"
@@ -138,6 +141,48 @@ TEST(ScriptText, ExtractedSpanishSphedaScriptMatches) {
     }
 }
 
+TEST(ScriptText, SpanishJumpGateMenusListEveryDestination) {
+    // The script offers five destinations in the first f04 menu and four in the others.
+    const std::array<std::pair<std::string_view, std::size_t>, 3> menus{
+        {{"map/f/f04/f04_5.stb", 5}, {"map/f/f04/f04_5.stb", 4}, {"map/s/s30/s30_5.stb", 4}}
+    };
+    const std::array<std::span<const script_text::Line>, 3> lines{
+        script_text::Find(menus[0].first).first(1), script_text::Find(menus[1].first).subspan(1), script_text::Find(menus[2].first)};
+    for (std::size_t i = 0; i < menus.size(); ++i) {
+        ASSERT_EQ(lines[i].size(), 1u) << menus[i].first;
+        const std::string_view text = lines[i].front().text;
+        EXPECT_EQ(static_cast<std::size_t>(std::count(text.begin(), text.end(), '\n')), menus[i].second) << text;
+        EXPECT_FALSE(text.ends_with('\n')) << text;
+        EXPECT_LE(LongestLine(text), 40u) << text;
+    }
+    EXPECT_TRUE(script_text::Find("map/f/f04/f04_1.stb").empty());
+    EXPECT_TRUE(script_text::Find("map/s/s30/s30_4.stb").empty());
+}
+
+TEST(ScriptText, ExtractedSpanishJumpGateScriptsMatch) {
+    const char *data = std::getenv("DC2_DATA");
+    if (!data) {
+        GTEST_SKIP() << "DC2_DATA supplies the extracted scripts";
+    }
+    for (const std::string_view key : {"map/f/f04/f04_5.stb", "map/s/s30/s30_5.stb"}) {
+        const auto path = std::filesystem::path(data) / key;
+        if (!std::filesystem::is_regular_file(path)) {
+            GTEST_SKIP() << "DC2_DATA supplies the extracted scripts";
+        }
+        std::ifstream              in(path, std::ios::binary);
+        std::vector<unsigned char> bytes{std::istreambuf_iterator<char>(in), std::istreambuf_iterator<char>()};
+        const std::size_t          size = bytes.size();
+        bytes.resize(size + script_text::Extra(key));
+
+        ASSERT_EQ(script_text::Patch(key, bytes.data(), size), bytes.size()) << key;
+        const auto code = static_cast<std::size_t>(Read32(bytes, 8));
+        for (const script_text::Line &line : script_text::Find(key)) {
+            const std::size_t at = code + static_cast<std::size_t>(Read32(bytes, line.push + 8));
+            EXPECT_EQ(std::string(reinterpret_cast<const char *>(bytes.data() + at)), line.text) << key;
+        }
+    }
+}
+
 TEST(ScriptText, SpanishSphedaLessonTextIsCorrected) {
     constexpr std::string_view key = "event/e300/e314/e314_5.txt";
     std::string                text = "@3140050\r\nNo tienes que acordarte de nada m\xe1s.\r\n@3140055\r\nDe azul a rojo, de negro a azul. "