rpmlint errors

[TimothyAsirJeyasing]

The following rpmlint errors are observed in 1.5.4 release to be fixed:

Shall we add shebang to the files which has execution permission but does not have shebang. These are added recently.
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/tendrl_ceph_cluster_iops.jinja
tendrl-node-agent.noarch: E: non-standard-dir-perm /usr/lib64/collectd/ceph 655
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/tendrl_gluster.jinja
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/latency.jinja
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/tendrl_gluster_brick_disk_stats.jinja
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/memory.jinja
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/swap.jinja
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/tendrl_ceph_cluster_utilization.jinja
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/mount_point.jinja
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/collectd.jinja
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/tendrl_ceph_node_network_throughput.jinja
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/dbpush.jinja
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/cpu.jinja
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/disk.jinja
tendrl-node-agent.noarch: E: script-without-shebang /usr/lib64/collectd/init.py
tendrl-node-agent.noarch: E: script-without-shebang /etc/collectd_template/network.jinja

tendrl-node-agent.noarch: E: zero-length /usr/lib/python2.7/site-packages/tendrl/node_agent/utils/definition_utils.py
Do we need this empty file ?

tendrl-node-agent.noarch: E: non-readable /etc/tendrl/node-agent/node-agent.conf.yaml 640
Is there any confidential information found in this file we are hiding to others?

A standard directory should have permission set to 0755. Do we need only 655 ? Please confirm
so that it can be fixed
tendrl-node-agent.noarch: E: non-standard-dir-perm /usr/lib64/collectd/gluster/heavy_weight 655
tendrl-node-agent.noarch: E: non-standard-dir-perm /usr/lib64/collectd/gluster 655
tendrl-node-agent.noarch: E: non-standard-dir-perm /usr/lib64/collectd/gluster/low_weight 655

The below files have shebang, but did not have executable permission. Do we need shebang for the following files.
tendrl-node-agent.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tendrl/node_agent/monitoring/collectd/commands/tendrl_monitoring_config_manager.py 644 /usr/bin/env
tendrl-node-agent.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tendrl/node_agent/monitoring/collectd/collectors/ceph/tendrl_ceph_cluster_iops.py 644 /usr/bin/python
tendrl-node-agent.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tendrl/node_agent/monitoring/collectd/collectors/ceph/tendrl_ceph_utilization.py 644 /usr/bin/python

tendrl-node-agent.noarch: W: no-manual-page-for-binary tendrl-node-agent
tendrl-node-agent.noarch: W: no-manual-page-for-binary tendrl-monitoring-config-manager
tendrl-node-agent.noarch: W: incoherent-version-in-changelog 1.5.4-1 ['1.5.4-1.el7.centos', '1.5.4-1.centos']

[TimothyAsirJeyasing]

Though most of the issues looks simple and harmless, we can not simply remove the file to fix rpmlint errors or we can not add shebang or remove executable permission or simply change the file permission at this point. It may affect the functionality of the program. We can do it slowly in a separate branch and should be tested well.

Also the questions are not answered for this issue.

[r0h4n]

@TimothyAsirJeyasing Please fix these issues.

[r0h4n]

@TimothyAsirJeyasing any updates?

[r0h4n]

@TimothyAsir Is this done or not?

[r0h4n]

@nthomas-redhat @TimothyAsir We have missed the deadline for this one, can you give some update about it?

[TimothyAsirJeyasing]

We need the questions to be answered. Kindly respective owners / others please answer the questions for each issues. So that we can fix these issues.