Ported events and hooks to 26.1.x - #2639
Conversation
|
Hey Albaza, before I actually review this, I wanted to ask if there was a reason some of the event files were moved into the client package? While the game may work, I believe the files are structured the way they are intentionally to create a clear separation between common and client code. |
I think it was an accidental move. I put everything back in its place |
…-events-and-hooks
|
|
||
| RenderSystem.enableBlend(); | ||
| RenderSystem.enableDepthTest(); | ||
| RenderSystem.setShaderColor(1F, 1F, 1F, (Mth.lerp(event.getPartialTick().getGameTimeDeltaTicks(), lastAurora, aurora)) / 60F * 0.5F); |
There was a problem hiding this comment.
Removing this line removes the fade in / fade out effect.
What replacement do you have in mind?
| buffer.addVertex(scale, y, scale).setColor(1F, 1F, 1F, 1F); | ||
|
|
||
| RenderSystem.enableBlend(); | ||
| RenderSystem.enableDepthTest(); |
There was a problem hiding this comment.
We also need to ensure these render states get ported over and not forgotten about.
Are you certain that blending and the depth buffer are working?
No description provided.