Repository navigation
Commit 2d6ca2b
sabtable: take vgi-rpc through vgi's re-export, never a direct dependency
The fixture no longer compiled: 32 errors, every one E0053/E0277 of the form
`expected vgi::RpcError, found vgi_rpc::RpcError`. Nothing in the trait API
had moved; the crate graph held two vgi-rpcs. sabtable required vgi-rpc
0.23.0 directly and patched crates.io to the sibling vgi-rpc-rust checkout,
while vgi-rust v0.35.0 wants 0.25.0 from crates.io. 0.x minors never unify,
so Cargo resolved 0.23.3 beside vgi's 0.25.0 and no trait impl could match.
The same failure was fixed by a version bump in c8247f7 and came back at the
next SDK minor.
vgi re-exports the crate (`vgi::vgi_rpc`, `vgi::{Result, RpcError}`)
precisely so a worker never names its version, so the fixture now imports
from there and drops both the direct dependency and the [patch.crates-io].
vgi-rust itself resolves vgi-rpc from crates.io (its workspace keeps any
local-checkout patch uncommitted), and the patch made this crate build
against whatever branch a sibling vgi-rpc-rust happened to be on — or, on a
0.26.0 checkout, not apply at all. vgi-rpc now resolves exactly once, to
the registry 0.25.0 that vgi-rust's own lockfile pins.
Also gates the BooleanArray/Float64Array import on emscripten, where the
browser fixtures that use it live, which clears the native build's only
warning.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 97518e8 commit 2d6ca2b
3 files changed
Lines changed: 26 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
31 | 30 | | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
37 | 36 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
24 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
25 | 31 | | |
26 | 32 | | |
27 | 33 | | |
| |||
0 commit comments