Skip to content

Commit a2dcd94

Browse files
authored
Merge pull request #28 from PriDebnath/testing
Fixed all test cases. Also installed fakeIndexDB.
2 parents 56f0a57 + ca7458c commit a2dcd94

12 files changed

Lines changed: 317 additions & 39 deletions

File tree

‎.github/workflows/test_frontend.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ permissions:
1111
id-token: write
1212

1313
jobs:
14-
deploy:
14+
test-frontend:
1515
runs-on: ubuntu-latest
1616
environment:
1717
name: github-pages

‎frontend/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@
103103
"eslint": "^9.39.1",
104104
"eslint-plugin-react-hooks": "^7.0.1",
105105
"eslint-plugin-react-refresh": "^0.4.24",
106+
"fake-indexeddb": "^6.2.5",
106107
"globals": "^16.5.0",
107108
"jsdom": "^28.0.0",
108109
"sass-embedded": "^1.97.2",

‎frontend/src/feature/quote/card/quote.card.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ const QuoteCard = (props: Props) => {
172172
e.preventDefault()
173173
onDelete(quote)
174174
}}
175-
aria-label="Delete quote"
175+
aria-label={"delete-" + quote.id}
176176
size={"sm"}
177177
>
178178
{<Trash />}

‎frontend/src/feature/quote/dialog/delete.dialog.tsx‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,11 @@ export default function DeleteQuoteDialog(props: Props) {
3030
return (
3131
<Dialog open={open} onOpenChange={setOpen}>
3232
<form onSubmit={handleFormSubmit} aria-label="delete-note-form">
33-
{/* <DialogTrigger asChild>
34-
<Button variant="outline">Add Quote</Button>
35-
</DialogTrigger> */}
33+
{/*
34+
<DialogTrigger asChild>
35+
<Button variant="outline">Add Quote</Button>
36+
</DialogTrigger>
37+
*/}
3638
<DialogContent className="">
3739
<DialogHeader>
3840
<DialogTitle>
@@ -52,7 +54,7 @@ export default function DeleteQuoteDialog(props: Props) {
5254
<Button
5355
type="submit"
5456
onClick={handleFormSubmit}
55-
aria-label="delete-note"
57+
aria-label="delete"
5658
variant={'destructive'}
5759
className="">
5860
Delete Quote

‎frontend/src/feature/quote/dialog/setting.dialog.tsx‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,11 @@ export function SettingComponent(props: Props) {
4646
const lastDeployed = useLastDeployed()
4747

4848
return (
49-
<Dialog open={open} onOpenChange={setOpen}>
50-
<DialogTrigger asChild>
49+
<Dialog open={open} onOpenChange={setOpen}
50+
51+
>
52+
<DialogTrigger asChild
53+
aria-label="settings-button">
5154
<Button
5255
variant="outline"
5356
size="icon"
@@ -59,7 +62,8 @@ export function SettingComponent(props: Props) {
5962

6063
<DialogContent
6164
className="p-4 gap-2 max-h-[90vh] overflow-auto"
62-
aria-describedby="Settings">
65+
aria-describedby="Settings"
66+
aria-label="settings">
6367
<DialogHeader>
6468
<DialogTitle>Settings</DialogTitle>
6569
<DialogDescription>

‎frontend/src/feature/quote/list.quote.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ export function ListQuote(props: Props) {
3030
<Masonry
3131
breakpointCols={breakpointCols}
3232
className="flex gap-2"
33+
aria-label="loading"
3334
columnClassName={columnClassName}
3435
>
3536
{Array.from({ length: 3 }).map((_, i) => {
@@ -55,7 +56,7 @@ export function ListQuote(props: Props) {
5556
}
5657

5758
return (
58-
<div aria-label='list'>
59+
<div aria-label='list-box'>
5960
<Masonry
6061
breakpointCols={breakpointCols}
6162
className="flex gap-2"

‎frontend/src/feature/quote/popover/filter.popover.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ interface TagFilterProps {
1515
onChange: (tags: string[]) => void
1616
}
1717

18-
export function TagFilter({ tags, value, onChange }: TagFilterProps) {
18+
export function TagFilter({ tags, value, onChange }: TagFilterProps) {
1919
const [open, setOpen] = useState(false)
2020

2121
const toggleTag = (tag: string) => {
Lines changed: 257 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,257 @@
1+
import { QuoteListPage as Component } from "./quote-list.page"
2+
import { userEvent } from "@testing-library/user-event"
3+
import { router } from "@/provider/tanstack-router.provider"
4+
import { renderWithFileRoutes } from "@/test/file-route-utils"
5+
import { beforeEach, describe, expect, it, vi } from "vitest"
6+
import { logDOM, screen, waitFor, waitForElementToBeRemoved } from "@testing-library/react"
7+
8+
// hooks
9+
import { useGetAllQuoteDetails } from "@/api-hook/use-get-all-quote-details.hook"
10+
11+
// db actions
12+
import { deleteQuoteWithLinks } from "@/db/quote_tags.db"
13+
import { toggleQuotePinned } from "@/db/quote.db"
14+
15+
// store
16+
import { useSortStore } from "@/store/use-sort.store"
17+
import type { QuoteDetails } from "@/model/index.model"
18+
19+
vi.mock("@/api-hook/use-get-all-quote-details.hook")
20+
const mockUseGetAllQuoteDetails = vi.mocked(useGetAllQuoteDetails)
21+
type GetAllQuotesReturn = ReturnType<typeof useGetAllQuoteDetails>
22+
23+
vi.mock('@/db/quote_tags.db')
24+
const mockDeleteQuoteWithLinks = vi.mocked(deleteQuoteWithLinks)
25+
26+
beforeEach(() => {
27+
///reset mock value
28+
mockUseGetAllQuoteDetails.mockReturnValue({
29+
data: undefined,
30+
isLoading: false,
31+
error: undefined,
32+
refetch: vi.fn()
33+
})
34+
})
35+
36+
describe(Component.name, () => {
37+
describe("rendering", () => {
38+
it("renders page with header and search", async () => {
39+
await router.navigate({ to: "/" })
40+
await renderWithFileRoutes(<Component />)
41+
const loader = await screen.queryByLabelText("loading-list")
42+
if (loader) {
43+
expect(await loader).toBeInTheDocument()
44+
await waitForElementToBeRemoved(loader, { timeout: 8000 })
45+
}
46+
47+
const list = await screen.queryByLabelText("list")
48+
expect(await list).toBeInTheDocument()
49+
50+
expect(await screen?.findByLabelText("sticky-header")).toBeInTheDocument()
51+
expect(await screen?.findByLabelText("search-note")).toBeInTheDocument()
52+
expect(await screen?.findByLabelText("search-icon")).toBeInTheDocument()
53+
expect(await screen?.findByLabelText("settings-button")).toBeInTheDocument()
54+
})
55+
56+
it("renders loading list", async () => {
57+
mockUseGetAllQuoteDetails.mockReturnValue({
58+
data: undefined,
59+
isLoading: true,
60+
error: undefined,
61+
refetch: vi.fn(),
62+
} )
63+
64+
await router.navigate({ to: "/" })
65+
await renderWithFileRoutes(<Component />)
66+
67+
const loaderList = await screen.queryByLabelText("loading-list")
68+
if (loaderList) {
69+
expect(await loaderList).toBeInTheDocument()
70+
await waitForElementToBeRemoved(loaderList, { timeout: 8000 })
71+
}
72+
73+
const loader = await screen.queryByLabelText("loading")
74+
expect(await loader).toBeInTheDocument()
75+
logDOM(loader!)
76+
})
77+
78+
it("renders quotes when data exists", async () => {
79+
const testContent = "test quote"
80+
mockUseGetAllQuoteDetails.mockReturnValue({
81+
data: [
82+
{
83+
id: 1,
84+
text: testContent,
85+
pinned: false,
86+
tags: [{ id: 1, name: "life" }],
87+
},
88+
],
89+
isLoading: false,
90+
error: undefined,
91+
refetch: vi.fn(),
92+
} )
93+
94+
await router.navigate({ to: "/" })
95+
await renderWithFileRoutes(<Component />)
96+
97+
const loaderList = await screen.queryByLabelText("loading-list")
98+
if (loaderList) {
99+
expect(await loaderList).toBeInTheDocument()
100+
await waitForElementToBeRemoved(loaderList, { timeout: 8000 })
101+
}
102+
103+
expect(await screen.findByText(testContent)).toBeInTheDocument()
104+
})
105+
106+
it("shows error state", async () => {
107+
const errorMessage = "something went wrong"
108+
109+
mockUseGetAllQuoteDetails.mockReturnValue({
110+
data: undefined,
111+
isLoading: false,
112+
error: errorMessage,
113+
refetch: vi.fn(),
114+
} )
115+
116+
await router.navigate({ to: "/" })
117+
await renderWithFileRoutes(<Component />)
118+
const loaderList = await screen.queryByLabelText("loading-list")
119+
if (loaderList) {
120+
expect(await loaderList).toBeInTheDocument()
121+
await waitForElementToBeRemoved(loaderList, { timeout: 8000 })
122+
}
123+
expect(await screen.findByText(errorMessage, {exact: false})).toBeInTheDocument()
124+
})
125+
126+
it("renders add new button with navigation link", async () => {
127+
await router.navigate({ to: "/" })
128+
await renderWithFileRoutes(<Component />)
129+
130+
expect(await screen.findByLabelText("new")).toBeInTheDocument()
131+
})
132+
})
133+
134+
describe("search filtering", () => {
135+
it("filters quotes by search text", async () => {
136+
mockUseGetAllQuoteDetails.mockReturnValue({
137+
data: [
138+
{ id: 1, text: "hello world", tags: [] },
139+
{ id: 2, text: "goodbye world", tags: [] },
140+
],
141+
isLoading: false,
142+
error: undefined,
143+
refetch: vi.fn(),
144+
} )
145+
146+
await router.navigate({ to: "/" })
147+
await renderWithFileRoutes(<Component />)
148+
149+
const searchInput = await screen.findByLabelText("search-note")
150+
await userEvent.type(searchInput, "hello")
151+
152+
await waitFor(() => {
153+
expect(screen.getByText("hello world")).toBeInTheDocument()
154+
expect(screen.queryByText("goodbye world")).not.toBeInTheDocument()
155+
})
156+
})
157+
})
158+
159+
describe("tag filtering", () => {
160+
it("filters quotes by tag", async () => {
161+
const mockedData = {
162+
data: [
163+
{
164+
id: 1,
165+
text: "quote one",
166+
tags: [{ id: 1, name: "life" }],
167+
},
168+
{
169+
id: 2,
170+
text: "quote two",
171+
tags: [{ id: 2, name: "love" }],
172+
},
173+
],
174+
isLoading: false,
175+
error: undefined,
176+
refetch: vi.fn(),
177+
}
178+
mockUseGetAllQuoteDetails.mockReturnValue(mockedData)
179+
180+
await router.navigate({ to: "/" })
181+
await renderWithFileRoutes(<Component />)
182+
const loaderList = await screen.queryByLabelText("loading-list")
183+
if (loaderList) {
184+
expect(await loaderList).toBeInTheDocument()
185+
await waitForElementToBeRemoved(loaderList, { timeout: 8000 })
186+
}
187+
188+
const firstText = screen.queryByText(mockedData.data[0].text)
189+
const secondText = screen.queryByText(mockedData.data[1].text)
190+
191+
await expect(firstText).toBeInTheDocument()
192+
await expect(secondText).toBeInTheDocument()
193+
194+
const openFilter = await screen.queryByLabelText("open-filter")
195+
expect(await openFilter).toBeInTheDocument()
196+
await userEvent.click(openFilter!, {})
197+
198+
const tagBox = await screen.queryByLabelText("filter-by")
199+
expect(await tagBox).toBeInTheDocument()
200+
201+
const tagButton = await screen.queryByLabelText(
202+
"filter-by-" + mockedData.data[0].tags[0].name
203+
)
204+
await userEvent.click(tagButton!)
205+
const list = await screen.queryByLabelText("list")
206+
207+
expect(firstText).toBeInTheDocument()
208+
expect(secondText).not.toBeInTheDocument()
209+
})
210+
})
211+
212+
describe("interaction", () => {
213+
it("opens delete dialog and deletes quote", async () => {
214+
const firstItem = { id: 1, text: "delete me", tags: [{ id: 1, name: "life" }] }
215+
const mockedData: GetAllQuotesReturn = {
216+
data: [firstItem],
217+
isLoading: false,
218+
error: undefined,
219+
// refetch: vi.fn()
220+
refetch: vi.fn(async () => {
221+
mockedData.data = []
222+
return {} as Awaited<ReturnType<GetAllQuotesReturn["refetch"]>>
223+
})
224+
}
225+
mockUseGetAllQuoteDetails.mockReturnValue(mockedData)
226+
227+
await router.navigate({ to: "/" })
228+
await renderWithFileRoutes(<Component />)
229+
const loaderList = await screen.queryByLabelText("loading-list")
230+
if (loaderList) {
231+
expect(await loaderList).toBeInTheDocument()
232+
await waitForElementToBeRemoved(loaderList, { timeout: 8000 })
233+
}
234+
235+
const list = await screen.queryByLabelText("list")
236+
const firstText = screen.queryByText(mockedData?.data?.[0]?.text!)
237+
await expect(firstText).toBeInTheDocument()
238+
239+
const deleteBtn = await screen.findByLabelText("delete-" + firstItem.id)
240+
await userEvent.click(deleteBtn)
241+
// logDOM(deleteBtn!)
242+
243+
const deletePopup = await screen.findByLabelText("delete")
244+
await expect(deletePopup).toBeInTheDocument()
245+
246+
await userEvent.click(deletePopup, {})
247+
248+
await expect(mockDeleteQuoteWithLinks).toHaveBeenCalledWith(firstItem.id)
249+
await expect(mockedData.refetch).toHaveBeenCalled()
250+
251+
await expect(deletePopup).not.toBeInTheDocument()
252+
await expect(firstText).not.toBeInTheDocument()
253+
})
254+
255+
256+
})
257+
})

‎frontend/src/page/quote/quote-list/quote-list.page.tsx‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,9 @@ export function QuoteListPage() {
9595

9696
if (error) {
9797
return (
98-
<p className="w-full text-center text-destructive">
98+
<p
99+
aria-label='error'
100+
className="w-full text-center text-destructive">
99101
Error: {error}
100102
</p>
101103
)
@@ -108,7 +110,7 @@ export function QuoteListPage() {
108110
aria-label='sticky-header'
109111
className="gap-2 p-2 flex flex-col sticky top-0 z-20 bg-background rounded-b"
110112
>
111-
<div className="flex justify-between">
113+
<aside className="flex justify-between">
112114
<TagFilter
113115
tags={allTags}
114116
value={activeTags}
@@ -117,7 +119,7 @@ export function QuoteListPage() {
117119
<Suspense fallback={null}>
118120
<SettingComponent />
119121
</Suspense>
120-
</div>
122+
</aside>
121123
{/* Search */}
122124
<InputGroup>
123125
<InputGroupInput

0 commit comments

Comments
 (0)