Skip to content

Commit 0a2cfdf

Browse files
committed
render + interection test
1 parent f709751 commit 0a2cfdf

11 files changed

Lines changed: 173 additions & 70 deletions

File tree

‎.github/workflows/test_frontend.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
cd frontend
3636
pnpm install
3737
38-
- name: tes5 frontend
38+
- name: test frontend
3939
run: |
4040
cd frontend
4141
pnpm run test

‎frontend/src/feature/quote/dropdown/choose-tag.tsx‎

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ interface Props {
2323

2424
export function ChooseTagDropdown(props: Props) {
2525
const { onChoose } = props
26-
const [open, setOpen] = useState(false)
26+
const [open, setOpen] = useState(false)
2727

2828
const CATEGORY_TAGS = {
2929
emotion: [
@@ -85,19 +85,25 @@ export function ChooseTagDropdown(props: Props) {
8585

8686
return (
8787
<DropdownMenu open={open} onOpenChange={setOpen}>
88-
<DropdownMenuTrigger asChild>
88+
<DropdownMenuTrigger asChild
89+
aria-label="add-tag"
90+
>
8991
<Button
92+
9093
variant="outline"
9194
size="icon"
92-
className={
93-
cn("border-primary/10",
94-
open ? "text-primary" : ""
95-
)}
95+
className={
96+
cn("border-primary/10",
97+
open ? "text-primary" : ""
98+
)}
9699
>
97100
<PlusIcon />
98101
</Button>
99102
</DropdownMenuTrigger>
100-
<DropdownMenuContent className="w-56 m-0 p-0 " align="start">
103+
<DropdownMenuContent
104+
aria-label="tags"
105+
className="w-56 m-0 p-0 "
106+
align="start">
101107
<div className="sticky top-0 z-10 backdrop-blur-sm">
102108
<DropdownMenuLabel className=" ">Tags</DropdownMenuLabel>
103109
<DropdownMenuSeparator />
@@ -114,9 +120,12 @@ export function ChooseTagDropdown(props: Props) {
114120
return (
115121
<DropdownMenuItem
116122
key={tag}
123+
117124
onClick={() => onChoose(tag)}
118125
>
119-
# {tag}
126+
<span aria-label={tag}>
127+
# {tag}
128+
</span>
120129
</DropdownMenuItem>
121130
)
122131
})}
@@ -132,7 +141,7 @@ export function ChooseTagDropdown(props: Props) {
132141
onClick={() => onChoose(tag)}
133142
className="flex align-center"
134143
>
135-
# {tag}
144+
# {tag}
136145
</DropdownMenuItem>
137146
))
138147
}
File renamed without changes.

‎frontend/src/page/quote/quote.page.test.tsx‎

Lines changed: 0 additions & 49 deletions
This file was deleted.
Lines changed: 142 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,142 @@
1+
2+
import { QuotePage as Component } from './quote.page';
3+
import { createMemoryHistory } from '@tanstack/react-router';
4+
import { router } from '@/provider/tanstack-router.provider';
5+
import { renderWithFileRoutes } from '@/test/file-route-utils';
6+
import { beforeEach, describe, expect, it, test, vi } from 'vitest';
7+
import { createRouter, RouterProvider } from "@tanstack/react-router";
8+
import { act, logDOM, render, screen, waitFor, waitForElementToBeRemoved } from '@testing-library/react';
9+
import { userEvent } from '@testing-library/user-event';
10+
11+
/// mock hook
12+
import { useGetQuoteDetails } from '@/api-hook/use-get-quote-details.hook';
13+
vi.mock("@/api-hook/use-get-quote-details.hook")
14+
const mockUseGetQuoteDetails = vi.mocked(useGetQuoteDetails)
15+
16+
beforeEach(() => {
17+
18+
///reset mock value
19+
mockUseGetQuoteDetails.mockReturnValue({
20+
data: undefined,
21+
isLoading: false,
22+
error: undefined,
23+
})
24+
})
25+
26+
describe(Component.name, () => {
27+
describe("rendering", () => {
28+
29+
it("renders quote page: add mode", async () => {
30+
await router.navigate({ to: '/new' })
31+
await renderWithFileRoutes(<Component mode="add" />)
32+
const loader = screen.queryByLabelText("loading-editor")
33+
if (loader) {
34+
expect(await loader).toBeInTheDocument()
35+
await waitForElementToBeRemoved(loader, { timeout: 8000 })
36+
}
37+
const editor = await screen.findByLabelText("editor")
38+
expect(await editor).toBeInTheDocument()
39+
})
40+
41+
it("renders quote page: edit mode", async () => {
42+
const editorContent = "editor-content"
43+
const tagContent = "tag-content"
44+
mockUseGetQuoteDetails.mockReturnValue({
45+
data: {
46+
text: editorContent,
47+
id: 1,
48+
tags: [{ id: 1, name: tagContent }]
49+
},
50+
isLoading: false,
51+
error: undefined,
52+
})
53+
await router.navigate({ to: '/$quoteId', params: { quoteId: "1" } })
54+
await renderWithFileRoutes(<Component mode="edit" />)
55+
56+
const loader = screen.queryByLabelText("loading")
57+
if (loader) {
58+
expect(await loader).toBeInTheDocument()
59+
await waitForElementToBeRemoved(loader, { timeout: 8000 })
60+
}
61+
62+
const editor = await screen.findByLabelText("editor")
63+
const tagList = await screen.findByLabelText("tag-list")
64+
await expect(await editor).toBeInTheDocument()
65+
await expect(await tagList).toBeInTheDocument()
66+
// logDOM(tagList)
67+
await expect(await screen.findByText(editorContent)).toBeInTheDocument()
68+
await expect(await screen.findByLabelText(tagContent)).toBeInTheDocument()
69+
70+
})
71+
72+
it("shows loading indicator when fetching quote", async () => {
73+
mockUseGetQuoteDetails.mockReturnValue({
74+
data: undefined,
75+
isLoading: true,
76+
error: undefined,
77+
})
78+
79+
await router.navigate({ to: '/$quoteId', params: { quoteId: "1" } })
80+
await renderWithFileRoutes(<Component mode="edit" />)
81+
82+
expect(await screen.findByLabelText("loading")).toBeInTheDocument()
83+
})
84+
85+
it("should show error", async () => {
86+
const somethingBad = "bugs took over the entire tech world"
87+
mockUseGetQuoteDetails.mockReturnValue({
88+
data: undefined,
89+
isLoading: false,
90+
error: somethingBad
91+
})
92+
93+
router.navigate({ to: "/$quoteId", params: { quoteId: "1" } })
94+
renderWithFileRoutes(<Component mode='edit' />)
95+
96+
const errorElement = await screen.findByLabelText("error")
97+
expect(errorElement).toBeInTheDocument()
98+
99+
const badElement = await screen.findByText(somethingBad, { exact: false })
100+
await expect(badElement).toBeInTheDocument()
101+
})
102+
103+
104+
105+
})
106+
107+
describe("interaction", () => {
108+
109+
it("adds tag when chosen", async () => {
110+
await router.navigate({ to: '/new' })
111+
await renderWithFileRoutes(<Component mode="add" />)
112+
113+
const loader = screen.queryByLabelText("loading-editor")
114+
if (loader) {
115+
expect(await loader).toBeInTheDocument()
116+
await waitForElementToBeRemoved(loader, { timeout: 8000 })
117+
}
118+
119+
const editor = await screen.findByLabelText("editor")
120+
expect(await editor).toBeInTheDocument()
121+
122+
const addTag = screen.queryByLabelText("add-tag")
123+
expect(await addTag).toBeInTheDocument()
124+
await userEvent.click(addTag!)
125+
126+
const tags = screen.queryByLabelText("tags")
127+
expect(await tags).toBeInTheDocument()
128+
129+
const tagGroup = screen.getByText("relationship", { exact: false })
130+
expect(await tagGroup).toBeInTheDocument()
131+
await userEvent.click(tagGroup!)
132+
// logDOM(tagGroup!)
133+
134+
const tag = screen.getByText("kindness", { exact: false })
135+
expect(await tag).toBeInTheDocument()
136+
// logDOM(tag!)
137+
})
138+
139+
})
140+
141+
});
142+

frontend/src/page/quote/quote.page.tsx renamed to frontend/src/page/quote/quote/quote.page.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ export function QuotePage(props: Props) {
207207

208208
{isLoading && <div aria-label="loading" >Loading...</div>}
209209

210-
{error && <div className="text-destructive">Error: {error}</div>}
210+
{error && <div aria-label="error" className="text-destructive">Error: {error}</div>}
211211

212212

213213
<div className="p-4 flex flex-col gap-4">
@@ -239,7 +239,9 @@ export function QuotePage(props: Props) {
239239
*/}
240240
<div className="">
241241
<TagField onChoose={onTagChoose} />
242-
<div className="flex flex-wrap gap-2">
242+
<div
243+
aria-label='tag-list'
244+
className="flex flex-wrap gap-2">
243245
{
244246
quoteData?.tags && quoteData?.tags.length > 0 && (
245247
quoteData?.tags.map((tag) => {
@@ -255,9 +257,8 @@ export function QuotePage(props: Props) {
255257
}}
256258
>
257259
<Badge
258-
259260
variant={'outline'}
260-
261+
aria-label={tag}
261262
className=" bg-primary/10 border-primary/30 text-primary/90"
262263
>
263264
#{tag}

‎frontend/src/routeTree.test.tsx‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
// // https://tanstack.com/router/latest/docs/how-to/test-file-based-routing
22
import { routeTree } from './routeTree.gen'
33
import { describe, it, expect } from 'vitest'
4-
import { act, screen, waitForElementToBeRemoved } from '@testing-library/react'
5-
import { QuoteListPage } from "@/page/quote/quote-list.page"
64
import { router } from './provider/tanstack-router.provider'
75
import { renderWithFileRoutes } from '@/test/file-route-utils';
6+
import { QuoteListPage } from "@/page/quote/quote-list/quote-list.page"
7+
import { act, screen, waitForElementToBeRemoved } from '@testing-library/react'
88

99
describe('Generated Route Tree', () => {
1010
it('should generate route tree from file structure', () => {
@@ -30,7 +30,6 @@ describe('Generated Route Tree', () => {
3030
const routePaths = getAllRoutePaths(routeTree)
3131
console.log({ routePaths });
3232

33-
3433
// Test that expected routes are present
3534
expect(routePaths)?.toContain('/')
3635
expect(routePaths)?.toContain('new')

‎frontend/src/routes/$quoteId.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { createFileRoute, lazyRouteComponent } from '@tanstack/react-router'
22

33
export const Route = createFileRoute('/$quoteId')({
44
component: lazyRouteComponent(() =>
5-
import('@/page/quote/quote.page').then(mod => ({
5+
import('@/page/quote/quote/quote.page').then(mod => ({
66
default: () => <mod.QuotePage mode="edit" />,
77
})),
88
),

‎frontend/src/routes/index.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { createFileRoute, lazyRouteComponent } from '@tanstack/react-router'
22

33
export const Route = createFileRoute('/')({
44
component: lazyRouteComponent(() =>
5-
import('@/page/quote/quote-list.page').then(mod => ({ default: mod.QuoteListPage })),
5+
import('@/page/quote/quote-list/quote-list.page').then(mod => ({ default: mod.QuoteListPage })),
66
),
77
})
88

‎frontend/src/routes/new.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { QuotePage } from '@/page/quote/quote.page'
1+
import { QuotePage } from '@/page/quote/quote/quote.page'
22
import { createFileRoute } from '@tanstack/react-router'
33

44
export const Route = createFileRoute('/new')({

0 commit comments

Comments
 (0)