Skip to content

Commit 76de683

Browse files
committed
perf(logs): Stop building debug log messages that are discarded in production
OpenSILEX/opensilex-dev!1596
1 parent 6cde2fb commit 76de683

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

‎opensilex-main/src/main/resources/logback.xml‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,14 @@
3434
</appender>
3535

3636

37-
<root>
37+
<!-- Classes listed as <debug> in the filter must also be enabled at DEBUG here, since the root level stops them before the filter -->
38+
<logger name="org.opensilex.unit.test.AbstractUnitTest" level="DEBUG"/>
39+
<logger name="org.opensilex.integration.test.AbstractIntegrationTest" level="DEBUG"/>
40+
<logger name="org.opensilex.integration.test.AbstractSecurityIntegrationTest" level="DEBUG"/>
41+
<logger name="org.apache.catalina.valves.StuckThreadDetectionValve" level="DEBUG"/>
42+
43+
<!-- Without a level the root logger defaults to DEBUG: every debug message would be built, then dropped by LogFilter -->
44+
<root level="${opensilex.log.level}">
3845
<appender-ref ref="STDOUT" />
3946
</root>
4047
</configuration>

‎opensilex-release/src/main/assembly/logback.xml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@
5252
</appender>
5353

5454

55-
<root>
55+
<!-- Without a level the root logger defaults to DEBUG: every debug message would be built, then dropped by LogFilter.
56+
Classes uncommented as <debug> above also need a <logger name="..." level="DEBUG"/> entry. -->
57+
<root level="${opensilex.log.level}">
5658
<appender-ref ref="STDOUT" />
5759
<appender-ref ref="FILE" />
5860
</root>

0 commit comments

Comments
 (0)