From fda353970baf98a8078809d7914223562c65b0a2 Mon Sep 17 00:00:00 2001 From: Ethan Clark Date: Fri, 19 Jun 2026 11:55:29 -0600 Subject: [PATCH 1/2] Add bss boot image set --param flag for setting the image parameter name (no documentation) Signed-off-by: Ethan Clark --- cmd/bss/boot/image/set.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/cmd/bss/boot/image/set.go b/cmd/bss/boot/image/set.go index 66a51ab0..e3e12ea2 100644 --- a/cmd/bss/boot/image/set.go +++ b/cmd/bss/boot/image/set.go @@ -158,11 +158,18 @@ See ochami-bss(1) for more details.`, } } + image_param_name, err := cmd.Flags().GetString("param") + if err != nil { + log.Logger.Error().Err(err).Msg("unable to get image param name") + cli.LogHelpError(cmd) + os.Exit(1) + } + errorsOccurred := false for bpIdx, bp := range bps { // Edit parameters for nodes k := kargs.NewKargs([]byte(bp.Params)) - k.SetKarg("root", args[0]) + k.SetKarg(image_param_name, args[0]) bps[bpIdx].Params = k.String() // Send modified params back to BSS @@ -187,6 +194,7 @@ See ochami-bss(1) for more details.`, // Create flags bootImageSetCmd.Flags().StringSliceP("xname", "x", []string{}, "one or more xnames whose boot parameters to set") bootImageSetCmd.Flags().StringSliceP("mac", "m", []string{}, "one or more MAC addresses whose boot parameters to set") + bootImageSetCmd.Flags().StringP("param", "p", "root", "set the image parameter name") bootImageSetCmd.Flags().Int32SliceP("nid", "n", []int32{}, "one or more node IDs whose boot parameters to set") bootImageSetCmd.MarkFlagsOneRequired("xname", "mac", "nid") From 856d07b542585c54c336ba36f049987deb9a14eb Mon Sep 17 00:00:00 2001 From: Ethan Clark Date: Fri, 19 Jun 2026 12:43:14 -0600 Subject: [PATCH 2/2] fix(bss): make boot image set --param usage more readable Signed-off-by: Ethan Clark --- cmd/bss/boot/image/set.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/bss/boot/image/set.go b/cmd/bss/boot/image/set.go index e3e12ea2..255952ab 100644 --- a/cmd/bss/boot/image/set.go +++ b/cmd/bss/boot/image/set.go @@ -194,7 +194,7 @@ See ochami-bss(1) for more details.`, // Create flags bootImageSetCmd.Flags().StringSliceP("xname", "x", []string{}, "one or more xnames whose boot parameters to set") bootImageSetCmd.Flags().StringSliceP("mac", "m", []string{}, "one or more MAC addresses whose boot parameters to set") - bootImageSetCmd.Flags().StringP("param", "p", "root", "set the image parameter name") + bootImageSetCmd.Flags().StringP("param", "p", "root", "set the kernel parameter name that the image is passed with") bootImageSetCmd.Flags().Int32SliceP("nid", "n", []int32{}, "one or more node IDs whose boot parameters to set") bootImageSetCmd.MarkFlagsOneRequired("xname", "mac", "nid")