[Olen]

• openplantbook.get removes its in-flight placeholder in a finally whenever the fetch did not finish: on any error or cancellation, not only the three it handles.

Before, an unexpected error (a network error, for example) left the placeholder behind, so every later request for that species waited 10 seconds and failed until the integration was reloaded.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

Pending API request cleanup can raise KeyError during integration unload or delete a newer request’s cache entry after reload.

1 open issue

• Use the original cache when cleaning up pending API requests · New

What changed in this PR

This PR updates openplantbook.get to clear in-flight placeholders after unexpected errors or cancellation, allowing later requests for the same species to retry.

Changes:

• Move failed-fetch cleanup into a finally block.
• Add a regression test confirming a request succeeds after an unexpected network error.

File	Description
tests/​test_init.py	Tests recovery after an unexpected API error.
custom_components/​openplantbook/​__init__.py	Centralizes placeholder cleanup for unsuccessful fetches.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

A cancellation regression test is still missing to verify that cancellation propagates, the placeholder is removed, and a subsequent request succeeds.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Add a regression test for cancellation cleanup and retry

custom_components/​openplantbook/​__init__.py:271

Please add a cancellation regression test alongside the new ConnectionError test: cancel a request while the mocked API call is pending, verify that cancellation propagates and the placeholder is removed, then verify that a subsequent request succeeds. The current test does not protect the cancellation behavior explicitly promised by this change; it would also pass with cleanup that catches only Exception, which excludes asyncio.CancelledError.

1 resolved since last review

• Use the original cache when cleaning up pending API requests

_{Review effort: Balanced}

[Olen]

The test from the last review summary is added in a5bacb6: test_get_plant_works_again_after_a_cancelled_request cancels a request while the API call is pending, checks that the cancellation propagates, and that the next request for the same species succeeds. It fails when the cleanup catches only Exception (checked), while the network-error test still passes then.