Use depth from eclGrid instead of recomputing it. - #7327
Draft
totto82 wants to merge 1 commit into
Draft
Conversation
Member
Author
|
jenkins build this please |
Member
Author
|
I made a sloping aquifer case where DEPTH is set like this EDIT
ADD
'DEPTH' -0.00 1 1 1 1 1 10 /
'DEPTH' -5.10 2 2 1 1 1 10 /
-- ---- etc.
'DEPTH' -494.90 98 98 1 1 1 10 /
'DEPTH' -500.00 99 99 1 1 1 10 /
/
Plume migrates upward on the "flat grid" as it should since depth is modified. |
totto82
added
the
manual:enhancement
DEPTH array is used directly if DEPTH is edited in the EDIT section. Note EclGrid can not be used directly as it is only available on rank 0.
totto82
force-pushed
the
depth_from_eclgrid
branch
from
August 18, 2026 08:20
7a927c0 to
7ac5499
Compare
Member
Author
|
jenkins build this please |
Member
|
How is this supposed to work if the model has local grids? |
Member
Author
It won't work. i.e., the PR needs a guard against using LGR + DEPTH in EDIT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, this makes it possible to use DEPTH set in the EDIT section
Follow up on.
OPM/opm-common#5181
Note 2: I had to use the DEPTH array directly, rather than just the depth from eclgrid, to make it work in parallel.