test(deploy): behavior-keyed registry-read mocks; drop stale route-parity list

The live-config diff read (#826) consumed one scripted read that the
publish-train unit tests had allocated to the idempotence check — the train
then correctly detected "already published" and skipped the transaction,
breaking the submit/txHash assertions. Key the fakes on "has the submit
happened" instead of call order so future pre-submit reads cannot
re-choreograph them.

handlers-structure's hardcoded registerFns list duplicated plugin.ts and
rotted on registerVerify; contract-router parity stays covered by the
real-builder composer test.

Author: elliotBraem

packages/everything-dev/tests/unit/deploy-train-service.test.ts

@@ -153,7 +153,11 @@ describe("DeployTrainService", () => {
       RegistryStore.of({
         fetchConfig: (async () => {
           registryReads += 1;
-          if (registryReads === 1) throw new Error("No config found");
+          // Behavior-keyed, not call-count-keyed: every read misses until the
+          // submit has gone through the injected Signer tag, then reads serve
+          // the published bytes for the confirm legs — another train read
+          // added before submit must not re-choreograph this fake.
+          if (submitted.length === 0) throw new Error("No config found");
           return JSON.parse(JSON.stringify(configReady));
         }) as never,
         fetchHistory: (async () => {

packages/everything-dev/tests/unit/handlers-structure.test.ts

@@ -1,75 +1,8 @@
 import { describe, expect, it } from "vitest";
 import { bosContract } from "../../src/contract";
-import { registerBuild } from "../../src/handlers/build";
-import { registerConfig } from "../../src/handlers/config";
-import { registerDb } from "../../src/handlers/db";
-import { registerDeploy } from "../../src/handlers/deploy";
-import { registerDev } from "../../src/handlers/dev";
-import { registerImport } from "../../src/handlers/import";
-import { registerInit } from "../../src/handlers/init";
-import { registerKeys } from "../../src/handlers/keys";
-import { registerLock } from "../../src/handlers/lock";
-import { registerOps } from "../../src/handlers/ops";
-import { registerPlugins } from "../../src/handlers/plugins";
-import { registerProcesses } from "../../src/handlers/processes";
-import { registerSecrets } from "../../src/handlers/secrets";
-import type { BosBuilder } from "../../src/handlers/shared";
-import { registerSmoke } from "../../src/handlers/smoke";
-import { registerUpgrade } from "../../src/handlers/upgrade";
 import bosPlugin from "../../src/plugin";
 
-const registerFns = [
-  registerConfig,
-  registerPlugins,
-  registerDev,
-  registerBuild,
-  registerDeploy,
-  registerLock,
-  registerSmoke,
-  registerKeys,
-  registerSecrets,
-  registerProcesses,
-  registerInit,
-  registerImport,
-  registerUpgrade,
-  registerDb,
-  registerOps,
-];
-
-function makeStubBuilder(records: Map<string, number>): BosBuilder {
-  return new Proxy(
-    {},
-    {
-      get: (_target, prop) => {
-        if (typeof prop !== "string") return undefined;
-        const record = (handler: unknown) => {
-          records.set(prop, (records.get(prop) ?? 0) + 1);
-          return { route: prop, handler };
-        };
-        return {
-          handler: record,
-          effect: record,
-        };
-      },
-    },
-  ) as BosBuilder;
-}
-
-describe("handler module structure", () => {
-  it("registers every contract route exactly once", () => {
-    const records = new Map<string, number>();
-    const builder = makeStubBuilder(records);
-    const router = Object.assign({}, ...registerFns.map((register) => register(builder)));
-
-    const contractRoutes = Object.keys(bosContract).sort();
-    expect(contractRoutes.length).toBeGreaterThan(0);
-    expect([...records.keys()].sort()).toEqual(contractRoutes);
-    expect(Object.keys(router).sort()).toEqual(contractRoutes);
-    for (const [route, count] of records) {
-      expect(count, route).toBe(1);
-    }
-  });
-
+describe("handler module composition", () => {
   it("composer builds the full router through the real builder", () => {
     const router = new bosPlugin().createRouter({});
     expect(Object.keys(router).sort()).toEqual(Object.keys(bosContract).sort());

packages/everything-dev/tests/unit/publish-auth-guard.test.ts

@@ -198,11 +198,12 @@ describe("publishToFastKv publish.auth guard", () => {
     writeFileSync(join(configDir, "bos.config.json"), JSON.stringify(bosConfig, null, 2));
 
     fetchBosConfigFromFastKvMock.mockReset();
-    // preflight reachability read → miss, isConfigAlreadyPublished → miss,
-    // then the confirmation loop reads the raw on-disk config
+    // Behavior-keyed: every registry read misses until the relay submit has
+    // happened, then the read-back serves the raw on-disk config for the
+    // confirm legs — another pre-submit train read must not re-choreograph
+    // this mock.
     fetchBosConfigFromFastKvMock.mockImplementation(async () => {
-      const calls = fetchBosConfigFromFastKvMock.mock.calls.length;
-      if (calls <= 2) return null;
+      if (submitRegistryWriteDelegatedMock.mock.calls.length === 0) return null;
       return JSON.parse(readFileSync(join(configDir, "bos.config.json"), "utf-8")) as BosConfig;
     });
 

packages/everything-dev/tests/unit/publish-preflight-order.test.ts

@@ -512,10 +512,12 @@ describe("publishToFastKv preflight ordering", () => {
       },
     };
     const merged = mergeAuthoredOverPublished(published as never, authored as never);
-    let fetchCalls = 0;
+    // Behavior-keyed: reads serve the pre-publish bytes until the submit has
+    // happened, then the read-back serves the merged config — another
+    // pre-submit train read must not re-choreograph this mock.
     fetchBosConfigFromFastKvMock.mockImplementation(async () => {
-      fetchCalls += 1;
-      return fetchCalls <= 2 ? structuredClone(published) : structuredClone(merged);
+      if (submitRegistryWriteMock.mock.calls.length === 0) return structuredClone(published);
+      return structuredClone(merged);
     });
     openResolutionMock.mockResolvedValue({ config: bosConfig, rawConfig: authored } as never);
     submitRegistryWriteMock.mockResolvedValue({ success: true, txHash: "tx-1" });