Repository navigation
Commit 350beba
authored
fix(release): rc detection asks the registry, not the changeset count — a dispatch published ungated (#871)
The gate's rc detector read pending-changeset file counts, but the
changesets action decides a publish by 'any package version missing
from npm'. On a workflow_dispatch its changed-since-before filter gets
an empty before, the reader throws to zero, and the action read 'no
changesets' over hundreds of pending files — skipped the gate as a
'version-PR leg' (regression never ran) and attempted an ungated
publish of unvalidated rc packages straight at npm. It crashed
mid-every-plugin, so nothing landed; the hazard was real.
The detector now asks the registry the question the action asks: a
publish is imminent iff any publishable package's version is missing
from npm, and every dispatched release run gates regardless. Also
carries the changeset documenting the #869 revert.1 parent 6f8c846 commit 350beba
2 files changed
Lines changed: 41 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
| 84 | + | |
83 | 85 | | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
104 | 99 | | |
105 | | - | |
| 100 | + | |
106 | 101 | | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
107 | 114 | | |
108 | 115 | | |
109 | 116 | | |
| |||
0 commit comments