Skip to content

Commit d55008a

Browse files
committed
updates
1 parent d5cbdea commit d55008a

402 files changed

Lines changed: 7647 additions & 13973 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.agents/skills/benchmark-coder/SKILL.md‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,24 @@ Use the runtime helpers explicitly in authored benchmark scripts:
2121

2222
```python
2323
from utils.submission import validate, simulate, submit_for_review
24-
from utils.preview import preview, preview_drawing, objectives_geometry
24+
from utils.preview import (
25+
list_render_bundles,
26+
objectives_geometry,
27+
pick_preview_pixel,
28+
pick_preview_pixels,
29+
preview,
30+
preview_drawing,
31+
query_render_bundle,
32+
)
2533
```
2634

2735
- `validate(result)` and `simulate(result)` are the required pre-handoff checks.
2836
- `submit_for_review(result)` is the final benchmark review handoff helper.
29-
- `preview(...)` and `preview_drawing()` are the evidence-generation paths; `objectives_geometry()` reconstructs benchmark objective overlays when needed.
37+
- `preview(...)` is the live scene and objective-overlay path; use `payload_path=True` only when the current workflow needs the live payload-path overlay. `preview_drawing()` is the drafting-package path and keeps the payload overlay off.
38+
- `objectives_geometry()` reconstructs benchmark objective overlays when needed.
39+
- `list_render_bundles()` selects the exact current or historical render bundle before you inspect media or point-pick results.
40+
- `query_render_bundle()` returns compact bundle metadata and frame slices without pulling the full media payload.
41+
- `pick_preview_pixel()` and `pick_preview_pixels()` resolve screen-space points against the bundle-local snapshot when click-to-world evidence matters.
3042
- `from utils.visualize import ...` is a compatibility alias, but `utils.preview` is the preferred namespace for new code.
3143

3244
## Geometry Contract
@@ -105,7 +117,7 @@ Do not invent fallback behavior to paper over contradictions. If the approved pl
105117
4. Run `python benchmark_script.py` as the canonical execution path.
106118
5. Fix import, geometry, labeling, or contract failures first.
107119
6. Run validation and simulation on the latest revision.
108-
7. Inspect render images or simulation media when they exist or when motion behavior is uncertain.
120+
7. Inspect render images or simulation media when they exist or when motion behavior is uncertain. If the question depends on bundle identity or pixel-to-world mapping, select the exact bundle with `list_render_bundles()` and query that bundle-local snapshot with `query_render_bundle()` or `pick_preview_pixel()` before changing geometry.
109121
8. Keep `todo.md` and `journal.md` synchronized with the work actually being done.
110122
9. Submit for review only when the latest revision is valid, simulated, and ready.
111123

‎.agents/skills/benchmark-plan-reviewer/SKILL.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ When planner drafts or evidence need visual checking, use the shared preview hel
1212
- `preview(...)` for live scene or preview-bundle inspection
1313
- `preview_drawing()` for drafted plan packages and orthographic evidence
1414
- `objectives_geometry()` when a preview scene needs benchmark objective overlays reconstructed
15+
- `list_render_bundles()` when exact bundle identity matters
16+
- `query_render_bundle()` when you need bundle metadata without the full media payload
17+
- `pick_preview_pixel()` / `pick_preview_pixels()` when a preview bundle needs click-to-world evidence
1518
- Prefer `utils.preview` for new code paths; `utils.visualize` is compatibility-only
1619

1720
## Precise Path Review
@@ -37,6 +40,7 @@ Treat `payload_trajectory_definition.yaml` as binding path-contract evidence whe
3740
- [ ] Strong reject plans that cannot state the payload trajectory clearly or that fail to derive it rigorously in `plan.md`; a missing trajectory estimate usually means downstream machinery is not grounded either.
3841
- [ ] Confirm `plan.md`'s detailed calculation section fully explains the numbers used to justify the precise path, including intermediate derivations for distances, timing, speeds, and clearances.
3942
- [ ] If render or drawing evidence exists, inspect it with `inspect_media(...)`. If drafting evidence must be materialized first, call `preview_drawing()` and inspect the persisted output.
43+
- [ ] If bundle identity or a pixel-to-world question matters, resolve the exact bundle with `list_render_bundles()` and query that bundle-local snapshot before deciding.
4044
- [ ] Treat `benchmark_plan_evidence_script.py` and `benchmark_plan_technical_drawing_script.py` as the inspectable source of the approved benchmark solution, not just helper files.
4145
- [ ] Verify cross-artifact consistency for labels, repeated quantities, COTS identities, zone geometry, randomization, bounds, runtime jitter, and motion facts. See `references/review_contracts.md`.
4246
- [ ] Verify `moved_object.material_id` resolves to a known material and `benchmark_assembly_definition.yaml` is a schema-valid full `AssemblyDefinition`.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
interface:
22
display_name: "Benchmark Plan Reviewer"
33
short_description: "Review benchmark planner handoffs against strict geometry, motion, precise-path, and scientifically derived calculation contracts."
4-
default_prompt: "Use this skill when reviewing benchmark planner handoffs before coding starts. Read the latest planner artifacts, the stage manifest, and the relevant architecture docs; follow the checklist in `SKILL.md` and `references/review_contracts.md`; inspect any render or drawing evidence with inspect_media(...) and preview_drawing() when needed; compare `assembly_definition.yaml.motion_forecast` to `payload_trajectory_definition.yaml` when present and decide whether the declared path is physically satisfiable; treat a missing or hand-wavy payload trajectory estimate as a strong reject because downstream machinery timing and sizing are then ungrounded; require `plan.md`'s detailed calculation section to fully derive the path-relevant distances, times, speeds, clearances, and tolerances; treat the planner evidence and technical-drawing scripts as the source of the approved benchmark contract; verify exact label, quantity, COTS identity, motion, timing, speed plausibility, and schema grounding; and write the stage-scoped decision/comments YAML pair under reviews/ before submitting the review gate."
4+
default_prompt: "Use this skill when reviewing benchmark planner handoffs before coding starts. Read the latest planner artifacts, the stage manifest, and the relevant architecture docs; follow the checklist in `SKILL.md` and `references/review_contracts.md`; inspect any render or drawing evidence with inspect_media(...) and preview_drawing() when needed, and use list_render_bundles(), query_render_bundle(), or pick_preview_pixel() when the review depends on exact bundle history or a screen-space point; compare `assembly_definition.yaml.motion_forecast` to `payload_trajectory_definition.yaml` when present and decide whether the declared path is physically satisfiable; treat a missing or hand-wavy payload trajectory estimate as a strong reject because downstream machinery timing and sizing are then ungrounded; require `plan.md`'s detailed calculation section to fully derive the path-relevant distances, times, speeds, clearances, and tolerances; treat the planner evidence and technical-drawing scripts as the source of the approved benchmark contract; verify exact label, quantity, COTS identity, motion, timing, speed plausibility, and schema grounding; and write the stage-scoped decision/comments YAML pair under reviews/ before submitting the review gate."

‎.agents/skills/benchmark-planner/SKILL.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ Use the shared preview helpers when evidence or objective overlays are part of t
2121
- `preview(...)` for live scene inspection and benchmark preview renders
2222
- `preview_drawing()` for drafting packages and orthographic plan evidence
2323
- `objectives_geometry()` when a benchmark preview needs reconstructed objective overlays
24+
- `list_render_bundles()` when the task depends on the exact bundle revision
25+
- `query_render_bundle()` when you need compact bundle metadata or frame slices
26+
- `pick_preview_pixel()` / `pick_preview_pixels()` when a preview bundle needs click-to-world evidence
2427
- Prefer `utils.preview` for new import paths; `utils.visualize` is compatibility-only
2528

2629
## Geometry Contract
@@ -79,7 +82,9 @@ Read these before drafting or revising the handoff:
7982
- Treat `benchmark_plan_technical_drawing_script.py` as display-only: it should not re-author a duplicate shape tree or a second copy of the benchmark geometry, only the orthographic drawing/view scaffolding for the same approved contract.
8083
- Keep every dimension formula-backed; if the handoff is missing a needed length, thickness, clearance, or placement datum, fix the source rather than guessing.
8184
- Use `preview(...)` for live scene previews and `preview_drawing()` for drafting packages; they are not interchangeable.
85+
- Use `payload_path=True` on `preview(...)` when the live payload-path overlay is part of the inspection.
8286
- When drawings are part of the handoff, inspect the drafted package with `preview_drawing()` before `submit_plan()`.
87+
- If the review depends on bundle identity or a click-to-world answer, select the exact bundle with `list_render_bundles()` and inspect or query that bundle-local snapshot instead of assuming the newest visible render is the right one.
8388
- Make the benchmark-owned motion contract explicit if any fixture moves. In this repo, keep each moving fixture to one explicit DOF axis and spell out the controller facts and limits.
8489
- Keep the moved object inside `build_zone` under static variation plus runtime jitter.
8590
- Keep goal and forbid zones non-overlapping with the moved object at spawn.

‎.agents/skills/benchmark-reviewer/SKILL.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ When preview evidence or objective overlays are present, use the shared preview
1414
- `preview(...)` for live scene previews or benchmark evidence inspection
1515
- `preview_drawing()` for drafting-package review evidence
1616
- `objectives_geometry()` when a benchmark preview needs reconstructed objective overlays
17+
- `list_render_bundles()` when exact bundle identity matters
18+
- `query_render_bundle()` when you need bundle metadata without the full media payload
19+
- `pick_preview_pixel()` / `pick_preview_pixels()` when a preview bundle needs click-to-world evidence
1720
- Prefer `utils.preview` for new code paths; `utils.visualize` is a compatibility alias
1821

1922
## Review Checklist
@@ -22,6 +25,7 @@ When preview evidence or objective overlays are present, use the shared preview
2225
- [ ] Read `benchmark_script.py`, `benchmark_definition.yaml`, `benchmark_assembly_definition.yaml`, `plan.md`, `todo.md`, `validation_results.json`, `simulation_result.json`, `scene.json`, `benchmark_plan_evidence_script.py`, `benchmark_plan_technical_drawing_script.py`, and any `renders/benchmark_renders/**` as read-only context.
2326
- [ ] Require validation and simulation success for the latest revision, and confirm `goal_reached` in the manifest/result.
2427
- [ ] Inspect render images with `inspect_media(...)` whenever they exist; if moving benchmark fixtures exist, inspect the latest dynamic simulation evidence before approval.
28+
- [ ] If bundle identity or a pixel-to-world question matters, resolve the exact bundle with `list_render_bundles()` and query that bundle-local snapshot before approval.
2529
- [ ] Treat `benchmark_plan_evidence_script.py` and `benchmark_plan_technical_drawing_script.py` as the inspectable source of the approved benchmark contract.
2630
- [ ] Verify geometric validity, solvability, runtime randomization, exact inventory grounding, and benchmark-side motion against the approved contract and observed evidence. See `references/review_contracts.md`.
2731
- [ ] Reject implementations that rely on free-form XYZ placement instead of selector-driven placement, explicit mates/joints, or the few absolute anchors already fixed by the approved plan.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
interface:
22
display_name: "Benchmark Reviewer"
33
short_description: "Review implemented benchmarks after validation and simulation."
4-
default_prompt: "Use this skill when validating the implemented benchmark after validation and simulation. Read `benchmark_script.py`, `benchmark_definition.yaml`, `benchmark_assembly_definition.yaml`, `validation_results.json`, `simulation_result.json`, `scene.json`, and any benchmark preview media as read-only; follow the checklist in `SKILL.md` and `references/review_contracts.md`; treat the planner evidence and technical-drawing scripts as the source of the approved benchmark contract; verify geometry, solvability, randomization, motion contracts, and inventory exactness; inspect render or video evidence when present; and write only the stage-scoped benchmark-execution review YAML pair under `reviews/` before submitting the review."
4+
default_prompt: "Use this skill when validating the implemented benchmark after validation and simulation. Read `benchmark_script.py`, `benchmark_definition.yaml`, `benchmark_assembly_definition.yaml`, `validation_results.json`, `simulation_result.json`, `scene.json`, and any benchmark preview media as read-only; follow the checklist in `SKILL.md` and `references/review_contracts.md`; treat the planner evidence and technical-drawing scripts as the source of the approved benchmark contract; verify geometry, solvability, randomization, motion contracts, and inventory exactness; inspect render or video evidence when present, and use list_render_bundles(), query_render_bundle(), or pick_preview_pixel() when exact bundle identity matters; and write only the stage-scoped benchmark-execution review YAML pair under `reviews/` before submitting the review."

‎.agents/skills/engineer-coder/SKILL.md‎

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: engineer-coder
3-
description: Problemologist engineering implementation role. Use when turning approved engineering handoffs into solution_script.py, solving engineering evals with bounded retries, selecting mechanism patterns, validating and simulating revisions, inspecting render evidence, preserving planner inventory exactness, grounding work in proof-backed plan.md contracts, or refusing an infeasible plan with plan_refusal.md.
3+
description: Problemologist engineering implementation role. Use when turning approved engineering handoffs into solution_script.py, solving engineering evals with bounded retries, selecting mechanism patterns, validating and simulating revisions, inspecting render evidence, querying render-bundle history or point-pick results, preserving planner inventory exactness, grounding work in proof-backed plan.md contracts, or refusing an infeasible plan with plan_refusal.md.
44
---
55

66
# Engineer Coder
@@ -34,19 +34,31 @@ Use the runtime helpers explicitly in authored engineer scripts:
3434

3535
```python
3636
from utils.submission import validate, simulate
37-
from utils.preview import preview, preview_drawing, objectives_geometry
37+
from utils.preview import (
38+
list_render_bundles,
39+
objectives_geometry,
40+
pick_preview_pixel,
41+
pick_preview_pixels,
42+
preview,
43+
preview_drawing,
44+
query_render_bundle,
45+
)
3846
```
3947

4048
- `validate(result)` and `simulate(result)` are the required pre-handoff checks.
4149
- `submit_for_review(result)` is available for supporting scripts that own the final handoff step.
42-
- `preview(...)` and `preview_drawing()` are the evidence-generation paths; `objectives_geometry()` reconstructs benchmark objective overlays when needed.
50+
- `preview(...)` is the live scene and objective-overlay path; use `payload_path=True` only when the current workflow needs the live payload-path overlay. `preview_drawing()` is the drafting-package path and keeps the payload overlay off.
51+
- `objectives_geometry()` reconstructs benchmark objective overlays when needed.
52+
- `list_render_bundles()` locates the exact current or historical render bundle instead of assuming the latest file on disk is the right snapshot.
53+
- `query_render_bundle()` returns compact frame/object slices when you need bundle metadata without the full media payload.
54+
- `pick_preview_pixel()` and `pick_preview_pixels()` resolve screen-space points against the bundle-local snapshot when you need click-to-world or batch point-pick evidence.
4355
- `from utils.visualize import ...` is a compatibility alias, but `utils.preview` is the preferred namespace for new code.
4456

4557
## What This Skill Owns
4658

4759
- Implementation strategy for the engineer-coder role.
4860
- File-level execution discipline for `solution_script.py`, `todo.md`, and `journal.md`.
49-
- Validation, simulation, media inspection, and review-submission behavior.
61+
- Validation, simulation, media inspection, render-history lookup, point-pick queries, and review-submission behavior.
5062
- The decision rules for when to load specialist skills and when to refuse a plan.
5163

5264
## What This Skill Does Not Own
@@ -111,7 +123,7 @@ Do not invent fallback behavior to bridge contradictions. If the handoff is inco
111123
04. Draft the smallest physically credible solution that can survive the declared runtime variation.
112124
05. Keep `solution_script.py` import-safe and bind the final object as `result`.
113125
06. Run a cheap syntax/import check, then a real validation probe, then simulation.
114-
07. Inspect render or video evidence as soon as motion is uncertain. Do not spend extra geometry effort before checking the first failing dynamic result.
126+
07. Inspect render or video evidence as soon as motion is uncertain. When the question depends on bundle identity or pixel-to-world mapping, use `list_render_bundles()`, `query_render_bundle()`, or `pick_preview_pixel()` against the exact bundle before spending extra geometry effort.
115127
08. Fix the narrowest failure mode and repeat.
116128
09. Submit for review only when the latest revision is actually ready.
117129
10. Anchor any binding numeric claim to the tightened `plan.md` proof structure; do not implement against prose-only assumptions when `ASSUMP-*` and `CALC-*` scaffolding is expected.
@@ -156,6 +168,8 @@ This role should behave like a high-confidence solver, not a wandering explorer.
156168
- Simulation success is necessary but not sufficient.
157169
- A passing validator does not excuse skipping the simulation video or frame evidence. Use the first dynamic result to confirm direction, capture, and stability.
158170
- If `preview(...)` evidence exists for the current revision, inspect the corresponding render bundle before finishing.
171+
- If render history matters, use `list_render_bundles()` and `query_render_bundle()` to select the exact bundle snapshot instead of assuming the newest visible render is the right one.
172+
- If a question depends on screen-space picking, use `pick_preview_pixel()` or `pick_preview_pixels()` against that bundle-local snapshot before changing geometry.
159173
- If render images exist for the current revision, inspect them with `inspect_media(...)` before finishing.
160174
- If the solution has moving behavior and simulation video exists, inspect the dynamic evidence before approval.
161175
- Treat `validation_results.json`, `simulation_result.json`, and render manifests as evidence inputs, not as substitutes for reasoning.
@@ -170,6 +184,7 @@ This role should behave like a high-confidence solver, not a wandering explorer.
170184
5. Robustness failure: widen tolerances to runtime jitter and remove exact-seed dependence.
171185
6. Directional motion failure: verify slope sign, handedness, and capture path from the actual simulation media before changing more geometry. Also check whether the preview is a front or rear view: preview yaw is clockwise from front, so rear views naturally swap left/right on screen and are not automatically an X-axis mirror.
172186
7. Reviewer failure: resolve the valid checklist items directly and ignore non-applicable demands.
187+
8. Render-history or point-pick failure: identify the exact bundle first, then inspect or query that bundle-local snapshot; do not infer coordinates from stale filenames or the latest artifact by default.
173188

174189
If the same blocker persists after one targeted fix, record it in `journal.md` and stop widening the search.
175190

0 commit comments

Comments
 (0)