Repository navigation
Release 0.10.12 (dev to main) - #413
Merged
Merged
Conversation
A dropdown menu held its anchor in viewport coordinates, taken once as it opened. On a page that scrolls around the chart, each re-placement put the list back at that spot on screen while its trigger scrolled away, so the timeframe, chart style and time zone menus came loose from their buttons. A menu opened with openAt had no anchor for those re-placements at all and fell back to the window's corner: a right-click menu or the alerts list jumped to the top of the window on the first scroll. The anchor is now held as an offset inside the host, for a trigger and for a point alike. The list keeps its place in the host: a page that scrolls the host carries it along, and a trigger that moves inside the host still leaves it where it opened, which is what the pin was for (starring a timeframe shifts the caret). A chart that fills its page sees no change. Co-authored-by: Cursor <cursoragent@cursor.com>
openAt took a viewport point only. A menu opened from a button it does not own as its trigger was given a point at the button's corner, or was placed by the caller through the machine's own reposition. The first covers the button once the list has to open on the other side. The second hands the kit no anchor, so the list is not kept in its host when the page scrolls. openAt now takes a rectangle as well, such as a button's box. The list opens on the menu's side of it, with its alignment and offsets, and on the rectangle's other side when that one lacks room. It is anchored like any other open menu, so it keeps its place in its host. Co-authored-by: Cursor <cursoragent@cursor.com>
fix(ui): an open menu keeps its place in its host when the page scrolls
feat(ui): a dropdown menu opens against a rectangle
… out Below 3 px per bar a candle is too narrow for a body and paints as one stick. That stick followed the wick setting alone, so a chart with the wick hidden painted nothing between 1 and 3 px per bar. Below 1 px, where bars share pixel columns, the sticks came back and ignored the setting. The stick now stands for the whole candle, in both tiers and both backends: high to low while the wick shows, open to close in the body color (the border's when only the border is on) when it does not, and nothing once the body, border and wick are all off. Co-authored-by: Cursor <cursoragent@cursor.com>
…ow-visibility Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # CHANGELOG.md
fix(chart): candles with the wick turned off stay visible when zoomed out
Co-authored-by: Cursor <cursoragent@cursor.com>
Release 0.10.12
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 2563e337-c83c-4458-a4fb-59cb157a22b0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the 0.10.12 release to
main: an open menu keeps its place in its host when the page scrolls (#409), candles with the wick turned off stay visible when zoomed out (#411), a kit dropdown menu that opens against a rectangle (#410), and the version update to 0.10.12 with@luxalgo/vela-ui0.4.3 (#412). Thev0.10.12tag follows this merge and triggers the publish.Note
Medium Risk
Touches shared UI positioning and both native render backends’ candle LOD paths; behavior is well covered by new tests but affects visible chart and toolbar UX at many zoom levels.
Overview
Release 0.10.12 bumps
@luxalgo/vela-uito 0.4.3 and ships two user-visible fixes plus kit improvements.Open menus stay attached to the chart. Dropdown anchors are stored in host coordinates (
pin/anchorRect) so lists move when the page scrolls the chart host, while an in-host trigger move (e.g. favorite chip) does not jump the open menu.openAtnow accepts a viewport rectangle (e.g.button.getBoundingClientRect()) for menus that do not own the trigger. Docs and jsdom tests cover scroll, reposition, and flip-side placement.Candles with wick off stay visible when zoomed out. Shared LOD helpers
candleStickExtentandcandleStickColordecide whether thin/aggregate tiers draw high–low sticks, open–close body sticks (body or border color), or nothing when every part is hidden. Canvas2d and WebGL2 backends andaggregateCandleColumnsuse abodyextent so hiding the wick alone no longer empties the pane; wide zoom behavior is unchanged when all parts are off.Changelogs and contributing notes document the menu behavior; new Vitest suites lock menu anchoring and cross-backend candle stick painting.
Reviewed by Cursor Bugbot for commit 69f938d. Bugbot is set up for automated code reviews on this repo. Configure here.